Skip to content

ci: pin cmake and avoid cloudcache#2415

Merged
SkrubbySkrubInAShrub merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:pin-cmake
May 25, 2026
Merged

ci: pin cmake and avoid cloudcache#2415
SkrubbySkrubInAShrub merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:pin-cmake

Conversation

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented May 24, 2026

prevents a faulty small cloud cache from failing to setup the build env on this PR:#2414

Also keeps cmake at a static version so it doesn't float and potentially break compilation again

Summary by CodeRabbit

  • Chores
    • Improved build environment setup for enhanced reproducibility and stability.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 80610a5a-872c-4539-b1a6-54bff1d7e804

📥 Commits

Reviewing files that changed from the base of the PR and between 61675d5 and e7945c7.

📒 Files selected for processing (1)
  • .github/actions/setup-build-environment/action.yaml

📝 Walkthrough

Walkthrough

The PR pins the CMake installer GitHub Action to version v4.3.3 instead of using the floating @latest tag, and explicitly sets useCloudCache: false to disable cloud caching in that step. The requested CMake version (~4.2.0) remains unchanged.

Changes

Setup Build Environment Configuration

Layer / File(s) Summary
CMake action version pinning and cache configuration
.github/actions/setup-build-environment/action.yaml
CMake installer action is pinned to v4.3.3 with cloud cache explicitly disabled via useCloudCache: false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • doodlum

Poem

🐰 A little pin, so small yet true,
@latest floats, now fixed for you—
v4.3.3 stands firm and still,
Cloud cache bows to explicit will!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and concisely summarizes the main changes: pinning CMake to a specific version and disabling cloud cache.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 YAMLlint (1.38.0)
.github/actions/setup-build-environment/action.yaml

[Errno 2] No such file or directory: '.github/actions/setup-build-environment/action.yaml'

🔧 Checkov (3.2.529)
.github/actions/setup-build-environment/action.yaml

2026-05-24 21:05:16,977 [MainThread ] [ERROR] Template file not found: .github/actions/setup-build-environment/action.yaml
2026-05-24 21:05:16,979 [MainThread ] [ERROR] Template file not found: .github/actions/setup-build-environment/action.yaml
2026-05-24 21:05:17,019 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with .github/actions/setup-build-environment/action.yaml
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/pytho

... [truncated 9329 characters] ...

setup-build-environment/action.yaml'
2026-05-24 21:05:17,081 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: '.github/actions/setup-build-environment/action.yaml'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub merged commit 6c369ad into community-shaders:dev May 25, 2026
5 checks passed
IgorAlanAlbuquerque pushed a commit to IgorAlanAlbuquerque/skyrim-community-shaders that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants