Skip to content

fix(hooks): promote snow render targets to fp16 for banding #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkrubbySkrubInAShrub merged 2 commits into from
May 31, 2026
Merged

fix(hooks): promote snow render targets to fp16 for banding #2410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae57bf5
fix(hooks): promote snow render targets to fp16 for banding
claude May 24, 2026
82a9313
Merge branch 'dev' into claude/banding-fix-snow-rt-precision
SkrubbySkrubInAShrub May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/Hooks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,29 @@ namespace Hooks
static inline REL::Relocation<decltype(thunk)> func;
};

// kSNOW / kSNOW_SWAP are created at R8G8B8A8_UNORM by vanilla; the snow shader
// writes accumulated wetness/sparkle values that exceed the 8-bit range and
// quantize into visible banding on tessellated snow. Promote to fp16 for headroom.
struct CreateRenderTarget_Snow
{
static void thunk(RE::BSGraphics::Renderer* This, RE::RENDER_TARGETS::RENDER_TARGET a_target, RE::BSGraphics::RenderTargetProperties* a_properties)
{
a_properties->format.set(RE::BSGraphics::Format::kR16G16B16A16_FLOAT);
func(This, a_target, a_properties);
}
static inline REL::Relocation<decltype(thunk)> func;
};

struct CreateRenderTarget_SnowSwap
{
static void thunk(RE::BSGraphics::Renderer* This, RE::RENDER_TARGETS::RENDER_TARGET a_target, RE::BSGraphics::RenderTargetProperties* a_properties)
{
a_properties->format.set(RE::BSGraphics::Format::kR16G16B16A16_FLOAT);
func(This, a_target, a_properties);
}
static inline REL::Relocation<decltype(thunk)> func;
};

// kNORMAL_TAAMASK_SSRMASK and its swap need UAV bind because DeferredCompositeCS
// writes vanilla-encoded normals through UAV1 (`normals.UAV` in Deferred::DeferredPasses),
// which feeds the post-pass vanilla SSAO chain (ISSAORawAO -> ISSAOComposite). Without
Expand Down Expand Up @@ -859,6 +882,8 @@ namespace Hooks

logger::info("Hooking BSShaderRenderTargets::Create::CreateRenderTarget(s)");
stl::write_thunk_call<CreateRenderTarget_Main>(REL::RelocationID(100458, 107175).address() + REL::Relocate(0x3F0, 0x3F3, 0x548));
stl::write_thunk_call<CreateRenderTarget_Snow>(REL::RelocationID(100458, 107175).address() + REL::Relocate(0x406, 0x409, 0x55E));
stl::write_thunk_call<CreateRenderTarget_SnowSwap>(REL::RelocationID(100458, 107175).address() + REL::Relocate(0x41C, 0x41F, 0x574));
stl::write_thunk_call<CreateRenderTarget_Normals>(REL::RelocationID(100458, 107175).address() + REL::Relocate(0x458, 0x45B, 0x5B0));
stl::write_thunk_call<CreateRenderTarget_NormalsSwap>(REL::RelocationID(100458, 107175).address() + REL::Relocate(0x46B, 0x46E, 0x5C3));
stl::write_thunk_call<CreateRenderTarget_MotionVectors>(REL::RelocationID(100458, 107175).address() + REL::Relocate(0x4F0, 0x4EF, 0x64E));
Expand Down
Loading