revert: "fix(dynamic cubemap): blend native cubemap fallback"

[doodlum]

Reverts #2328

Summary by CodeRabbit

• Bug Fixes

  • Improved reflection fallback behavior in dynamic cubemaps with automatic blend calculation.
  • Removed user-configurable fallback amount setting from the configuration menu.

• Chores

  • Updated feature version.

[coderabbitai]

📝 Walkthrough

Walkthrough

ReflectionFallbackAmount setting is completely removed from the DynamicCubemaps feature. Changes cascade from header definitions through C++ implementation and JSON serialization, to shader buffer layout and blend computation, with a corresponding version bump.

Changes

ReflectionFallbackAmount Removal

Layer / File(s)	Summary
Remove ReflectionFallbackAmount from Settings struct definition src/Features/DynamicCubemaps.h	Static constexpr fallback constants (kReflectionFallbackMin, kReflectionFallbackMax, kReflectionFallbackDefault) and the ReflectionFallbackAmount member field with padding are removed from DynamicCubemaps::Settings struct; alignment assertion is deleted.
Remove ReflectionFallbackAmount from C++ implementation src/Features/DynamicCubemaps.cpp	ReflectionFallbackAmount is removed from JSON serialization mapping, the ImGui "Native Cubemap Fallback" UI slider is deleted from DrawSettings(), and post-load clamping logic is removed from LoadSettings().
Update shader buffer layout and blend computation package/Shaders/Common/SharedData.hlsli, features/Dynamic Cubemaps/Shaders/DynamicCubemaps/InferCubemapCS.hlsl	CubemapCreatorSettings padding is adjusted from float2 pad0 to float3 pad0 due to EnabledSSR removal; InferCubemapCS blend weight changes from saturate(mipLevel / 7.0) * SharedData::cubemapCreatorSettings.ReflectionFallbackAmount to saturate(mipLevel / 7.0).
Bump feature version features/Dynamic Cubemaps/Shaders/Features/DynamicCubemaps.ini	Version updated from 2-3-2 to 2-3-1.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• community-shaders/skyrim-community-shaders#2328: Both PRs modify InferCubemapCS.hlsl's #if defined(REFLECTIONS) fallback blending logic; this PR removes the ReflectionFallbackAmount dependency while #2328 adds it.
• community-shaders/skyrim-community-shaders#1705: Both PRs modify DynamicCubemaps.ini by updating the feature version field.

Suggested reviewers

• alandtse
• davo0411

Poem

🐰 A cubemap setting bows its head,
ReflectionFallback now gone, no dread.
Mips and mips blend pure and light,
Settings trimmed with shader might. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The pull request title accurately describes the main objective: reverting a previous fix related to dynamic cubemap blending.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-2328-fix-dynamic-cubemap

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download