Skip to content

ci: set GH_REPO for release-notes#2349

Merged
alandtse merged 1 commit into
community-shaders:devfrom
alandtse:ci/release-notes-fix-gh-repo
May 15, 2026
Merged

ci: set GH_REPO for release-notes#2349
alandtse merged 1 commit into
community-shaders:devfrom
alandtse:ci/release-notes-fix-gh-repo

Conversation

@alandtse
Copy link
Copy Markdown
Collaborator

@alandtse alandtse commented May 15, 2026

Run 25871339509 (Release: Build Artifacts on tag v1.5.2) failed at the Generate combined release notes step:

##[error]Failed to fetch release body for v1.5.2:
failed to run git: fatal: not a git repository (or any of the parent directories): .git

The release job downloads artifacts but never runs actions/checkout, so gh release view falls back to git remote to infer the repo and dies. The existing release not found fallback grep doesn't match this error string, so the step exits 1 instead of treating an absent release as a clean empty-body case.

Fix: set GH_REPO in the step env so gh queries the API directly without the git fallback. Single-line, scoped to the broken step. No behavior change for the happy path.

Builds for v1.5.2 themselves succeeded (Flatrim, vs2026, shader unit tests, VR all green). The draft release exists and is sitting empty of artifacts — once this lands, re-dispatching Build Artifacts will finalize it. (Note: the workflow file at the dispatched ref is what executes, so re-dispatching on tag v1.5.2 won't pick up this fix; for v1.5.2 specifically, manual artifact upload to the draft is the unblock. This PR fixes the path for v1.5.3+.)

Summary by CodeRabbit

  • Chores
    • Improved reliability of the release notes generation process in CI/CD pipeline.

Review Change Stack

Run 25871339509 (Release: Build Artifacts on tag v1.5.2) failed at
the 'Generate combined release notes' step:

  ##[error]Failed to fetch release body for v1.5.2:
  failed to run git: fatal: not a git repository (or any of the
  parent directories): .git

The job downloads artifacts but never runs actions/checkout, so
gh release view falls back to 'git remote' to infer the repo and
dies. The 'release not found' fallback grep doesn't match this
error string, so the step exits 1 instead of treating the absent
release as a clean empty-body case.

Set GH_REPO in the step env so gh queries the API directly without
the git fallback. Single-line, scoped to the broken step.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

📝 Walkthrough

Walkthrough

The pull request adds explicit repository context to the GitHub Actions release workflow. The Generate combined release notes step now sets GH_REPO environment variable in addition to GH_TOKEN, ensuring the gh CLI can properly reference the repository when running gh release view without depending on implicit fallback behavior.

Changes

Release Workflow Repository Context

Layer / File(s) Summary
Explicit repository context for release notes generation
.github/workflows/release-build.yaml
The env block in the Generate combined release notes step gains GH_REPO alongside GH_TOKEN so the gh CLI has explicit repository context during gh release view operations without requiring code checkout.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested Reviewers

  • jiayev
  • davo0411

Poem

🐰 A whisper of context, explicit and clear,
GH_REPO joins the token, no guessing here—
The release notes flow swift, the repository known,
No checkout required, the path brightly shown.
Small change, big confidence! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately captures the main change: setting the GH_REPO environment variable in the release-notes workflow step.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alandtse alandtse changed the title ci: set GH_REPO so release-notes step works without checkout ci: set GH_REPO for release-notes May 15, 2026
@alandtse alandtse merged commit be27598 into community-shaders:dev May 15, 2026
7 checks passed
ParticleTroned pushed a commit to ParticleTroned/skyrim-community-shaders that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants