Skip to content

fix(truepbr): remove EnvmapData breaking MATOs#2336

Merged
SkrubbySkrubInAShrub merged 2 commits into
community-shaders:devfrom
soda3000:dev-2026-05-12
May 13, 2026
Merged

fix(truepbr): remove EnvmapData breaking MATOs#2336
SkrubbySkrubInAShrub merged 2 commits into
community-shaders:devfrom
soda3000:dev-2026-05-12

Conversation

@soda3000
Copy link
Copy Markdown
Contributor

@soda3000 soda3000 commented May 13, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Corrected projected material color scaling in physically-based rendering mode for improved visual accuracy.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 10f418cf-789c-4cdd-8e80-34e5f51a1a62

📥 Commits

Reviewing files that changed from the base of the PR and between 88a5358 and b19c87b.

📒 Files selected for processing (1)
  • package/Shaders/Lighting.hlsl
💤 Files with no reviewable changes (1)
  • package/Shaders/Lighting.hlsl

📝 Walkthrough

Walkthrough

A single-line adjustment to the TRUE_PBR projected-material shader path replaces the base color scaling factor from EnvmapData.x to MaterialObjectRGBScale, directly affecting how projected UV colors blend into the final material base color computation.

Changes

Projected Material Base Color Scaling

Layer / File(s) Summary
Projected material base color scaling with RGB scale
package/Shaders/Lighting.hlsl
In the TRUE_PBR projected-UV handling path, projBaseColor.xyz is now scaled by MaterialObjectRGBScale (clamped with max(0, ...)) instead of EnvmapData.x, altering how projected UV colors contribute to the material's base color before subsequent RMAOS interpolation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • doodlum
  • alandtse

Poem

A scale swap in shader light,
From EnvmapData to RGB bright,
Projected colors blend just right,
One line dances, makes it white— 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: removing EnvmapData usage that was breaking MATO (material object) functionality in the TruePBR shader path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

No actionable suggestions for changed features.

@soda3000
Copy link
Copy Markdown
Contributor Author

Some additional info about why this change is necessary:

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub merged commit 5080275 into community-shaders:dev May 13, 2026
10 of 11 checks passed
SkrubbySkrubInAShrub pushed a commit that referenced this pull request May 13, 2026
SkrubbySkrubInAShrub pushed a commit that referenced this pull request May 14, 2026
ParticleTroned pushed a commit to ParticleTroned/skyrim-community-shaders that referenced this pull request May 15, 2026
ParticleTroned pushed a commit to ParticleTroned/skyrim-community-shaders that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants