Skip to content

fix(upscaling): preserve D3D12 proxy swap chain #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 2 commits into from
May 15, 2026
+10 −3
Merged

fix(upscaling): preserve D3D12 proxy swap chain #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e0e6d
fix(upscaling): preserve D3D12 proxy swap chain for SKSE plugin compa…
jota2rz May 12, 2026
04fa796
Merge branch 'dev' into dev
jota2rz May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Features/Upscaling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,12 @@ HRESULT WINAPI hk_D3D11CreateDeviceAndSwapChainUpscaling(

if (upscaling.IsBackendInitialized()) {
upscaling.UpgradeBackendInterface((void**)&(*ppDevice));
upscaling.UpgradeBackendInterface((void**)&(*ppSwapChain));
// Don't wrap the swap chain with Streamline when using the D3D12
// proxy. The proxy's GetDevice() returns the D3D11 device for
// IID_ID3D11Device, which other SKSE plugins (e.g. SkyrimPlatform)
// rely on. Streamline's wrapper would bypass this override and
// forward to the underlying D3D12 swap chain, causing
// E_NOINTERFACE. The proxy must remain the outermost layer.
upscaling.SetBackendD3DDevice(*ppDevice);
// Some features (notably Reflex/PCL) may report availability only after device bind.
upscaling.CheckBackendFeatures(pAdapter);
Expand Down
6 changes: 4 additions & 2 deletions src/Hooks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,10 @@ struct IDXGISwapChain_Present
// OMGetRenderTargets to find a target to render overlays into. Without this, they
// get nullptr (we unbound everything for the ApplyHDR resource hazard) and their
// UI elements are invisible.
if (hdrReady && !frameGenActive) {
hdr->ClearUIBuffer(); // restores kFRAMEBUFFER.RTV to original backbuffer RTV
if (hdrReady) {
if (!frameGenActive) {
Comment thread
alandtse marked this conversation as resolved.
hdr->ClearUIBuffer(); // restores kFRAMEBUFFER.RTV to original backbuffer RTV
}
auto& data = globals::game::renderer->GetRuntimeData().renderTargets[RE::RENDER_TARGET::kFRAMEBUFFER];
globals::d3d::context->OMSetRenderTargets(1, &data.RTV, nullptr);
}
Expand Down
Loading