ci: fix Release: Hotfix Candidate PR step#2324
Merged
alandtse merged 1 commit intoMay 12, 2026
Merged
Conversation
Two bugs surfaced by run 25649556508:
1. Backtick command-substitution in PR body. source_desc (set on line
175) contains literal backticks. When inlined via
${{ steps.cherry.outputs.source_desc }} into the bash heredoc on
line 275, bash interprets them as command substitution —
'fix-only: command not found', 'v1.5.1: command not found'. Fix:
pass via step env so the value reaches bash as a normal variable
expansion that does not re-evaluate the contents.
2. Missing 'hotfix' label. gh pr create --label hotfix failed with
'could not add label: hotfix not found'. Fix: best-effort
gh label create hotfix before gh pr create, swallowing the error
if the label already exists.
Contributor
📝 WalkthroughWalkthroughThe hotfix release workflow now safely passes commit metadata ( ChangesHotfix Release Workflow Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jiayev
approved these changes
May 12, 2026
ParticleTroned
pushed a commit
to ParticleTroned/skyrim-community-shaders
that referenced
this pull request
May 15, 2026
ParticleTroned
pushed a commit
to ParticleTroned/skyrim-community-shaders
that referenced
this pull request
May 16, 2026
IgorAlanAlbuquerque
pushed a commit
to IgorAlanAlbuquerque/skyrim-community-shaders
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs surfaced by run 25649556508:
Backtick command-substitution in PR body.
source_desc(set on line 175) contains literal backticks. When inlined via${{ steps.cherry.outputs.source_desc }}into the bash heredoc on line 275, bash interprets them as command substitution —fix-only: command not found,v1.5.1: command not found. Fix: pass via stepenv:so the value reaches bash as a normal variable expansion that doesn't re-evaluate the contents.Missing
hotfixlabel.gh pr create --label hotfixfailed withcould not add label: 'hotfix' not found. Fix: best-effortgh label create hotfixbeforegh pr create, swallowing the error if the label already exists.Both fixes are scoped to the failing step. No behavior change beyond unblocking the candidate PR open.
Summary by CodeRabbit