refactor(weather-editor): match celllighting to lightingtemplate

[SkrubbySkrubInAShrub]

Both widgets edit the same values but have different priorities, so their layout not matching is nonsensical

Summary by CodeRabbit

• New Features

  • Search-driven rendering with enhanced discovery of cell lighting settings.

• UI/UX Improvements

  • Reorganized interface tabs and added collapsible sections for cell lighting parameters.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4dd6c980-e6ba-4917-a503-1bb93721f612

📥 Commits

Reviewing files that changed from the base of the PR and between 5a59442 and 800fbe0.

📒 Files selected for processing (1)

• src/WeatherEditor/Weather/CellLightingWidget.cpp

---

📝 Walkthrough

Walkthrough

The PR reorganizes the cell lighting widget UI by redefining tab categories from Colors/Directional Ambient/Advanced to Basic/Fog/DALC/Inheritance, refactoring tab rendering to conditionally display controls via search-driven helpers, and remapping searchable settings to the new tab identifiers.

Changes

Cell Lighting Widget Tab Reorganization

Layer / File(s)	Summary
Tab Identifier Constants src/WeatherEditor/Weather/CellLightingWidget.cpp	Tab label constants are updated from Colors, Directional Ambient, and Advanced to Basic, Fog, and DALC, while retaining Inheritance.
Tab Rendering & Layout src/WeatherEditor/Weather/CellLightingWidget.cpp	Basic tab now renders grouped, collapsible sections using a drawMatchedHeader helper conditioned on search matches. Fog and DALC tabs are refactored to use DrawSearchSectionIfMatches with grouped separators for fog colors/distances/properties and DALC specular/fresnel/directional color channels.
Searchable Settings Mapping src/WeatherEditor/Weather/CellLightingWidget.cpp	CollectSearchableSettings() remaps lighting keys from the old tab categories (kColors, kDirectionalAmbient, kAdvanced) to the new ones (kBasic, kFog, kDalc).

Estimated Code Review Effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly Related PRs

• community-shaders/skyrim-community-shaders#2133: Also modifies DALC/directional ambient lighting UI and replaces the TOD table with per-axis color controls.
• community-shaders/skyrim-community-shaders#2136: Also modifies CellLightingWidget.cpp tab contents for fog, DALC, and advanced lighting controls.

Suggested Reviewers

• alandtse
• davo0411

Poem

🐰 A rabbit hops through tabs so bright,
From Colors pale to Fog's soft light,
The DALC shines with directional glow,
Search helpers find what you must know!
The Basic way, the cleaner path—
Now lighting edits feel less wrath! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main objective: refactoring the cell lighting widget UI to match the lighting template widget layout and organization.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.20.0)

OpenGrep fatal error (exit code 2): [00.10][ERROR]: Error: exception Unix_error: No such file or directory stat src/WeatherEditor/Weather/CellLightingWidget.cpp
Raised by primitive operation at UTmp.replace_named_pipe_by_regular_file_if_needed in file "libs/commons/UTmp.ml", line 145, characters 8-27
Called from Scan_CLI.replace_target_roots_by_regular_files_where_needed.(fun) in file "src/osemgrep/cli_scan/Scan_CLI.ml", lines 1086-1087, characters 19-65
Called from List_.fast_map in file "libs/commons/List_.ml", line 81, characte

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download