chore(upscaling): replace slider toggles

[SkrubbySkrubInAShrub]

reaplace sliderInt with toggles that make sense for the type.

Summary by CodeRabbit

• Style
  • Enhanced Upscaling settings interface: "Method" selection now uses a dropdown menu, and toggle options (Frame Generation, Frame Limit, Reflex controls) are now presented as checkboxes for more intuitive interaction.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 40cae61d-16e8-4264-8007-1ea4f5b20d00

📥 Commits

Reviewing files that changed from the base of the PR and between 96005a4 and e8e63d4.

📒 Files selected for processing (1)

• src/Features/Upscaling.cpp

---

📝 Walkthrough

Walkthrough

The PR refactors UI controls in Upscaling::DrawSettings() across three settings sections: the "Method" selector switches from slider to dropdown, frame-generation toggles convert from sliders to checkboxes with preserved conditional gating, and Reflex settings adopt checkboxes while maintaining disabled-state behavior for dependent options.

Changes

Upscaling UI Control Refactoring

Layer / File(s)	Summary
Method Selection Control src/Features/Upscaling.cpp	"Method" selector replaces slider-based selection with ImGui::Combo driven by dynamically built mode label lists.
Frame Generation Controls src/Features/Upscaling.cpp	Frame generation, frame limit, and force-enable options convert from ImGui::SliderInt to ImGui::Checkbox while preserving BeginDisabled/EndDisabled gating tied to DX12 frame-generation availability and existing warning/info text.
Reflex Settings Controls src/Features/Upscaling.cpp	Low Latency Mode, Low Latency Boost, Markers To Optimize, and FPS Limit toggles replace slider controls with ImGui::Checkbox, preserving conditional disabled states based on low-latency mode and marker optimization availability; FPS Limit float value clamping and defaults are retained separately.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• community-shaders/skyrim-community-shaders#1524: Both PRs modify Upscaling::DrawSettings() UI logic; this PR refactors controls while #1524 adds a conditional restart warning in the same function.
• community-shaders/skyrim-community-shaders#1532: Both PRs modify UI code and labels in src/Features/Upscaling.cpp within Upscaling::DrawSettings().
• community-shaders/skyrim-community-shaders#1267: Both PRs touch frame generation UI and gating logic in Upscaling::DrawSettings(); this PR refactors controls while #1267 modifies frameGenAvailable logic.

Suggested reviewers

• soda3000
• doodlum

Poem

🐰 A flutter of controls, from sliders set free,
Checkboxes dancing where booleans used to be,
Combos for choices, more clear and more bright,
The UI blooms onward—a UI delight! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: replacing slider-based controls with checkbox toggles in the upscaling UI.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.20.0)

OpenGrep fatal error (exit code 2): [00.14][ERROR]: Error: exception Unix_error: No such file or directory stat src/Features/Upscaling.cpp
Raised by primitive operation at UTmp.replace_named_pipe_by_regular_file_if_needed in file "libs/commons/UTmp.ml", line 145, characters 8-27
Called from Scan_CLI.replace_target_roots_by_regular_files_where_needed.(fun) in file "src/osemgrep/cli_scan/Scan_CLI.ml", lines 1086-1087, characters 19-65
Called from List_.fast_map in file "libs/commons/List_.ml", line 81, characters 17-20
Called from S

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[doodlum]

screenshot?