Skip to content

fix: compiler remaining tasks #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 2 commits into from
May 5, 2026
Merged

fix: compiler remaining tasks #2276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fed05b3
Update ShaderCache.cpp
davo0411 May 4, 2026
853cda7
Potential fix for pull request finding
davo0411 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/ShaderCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2966,7 +2966,15 @@ namespace SIE

QueryPerformanceCounter(&end);
const double elapsedMs = static_cast<double>(end.QuadPart - start.QuadPart) * 1000.0 / freq.QuadPart;
const uint64_t remaining = compilationSet.totalTasks - compilationSet.completedTasks.load(std::memory_order_relaxed) - compilationSet.failedTasks.load(std::memory_order_relaxed);
// Use saturating math: without a lock, Clear() can zero totalTasks while completedTasks
// still reads high briefly, which would otherwise underflow uint64_t (logs as ~2^64-1).
const uint64_t total = compilationSet.totalTasks.load(std::memory_order_relaxed);
const uint64_t done = compilationSet.completedTasks.load(std::memory_order_relaxed) +
compilationSet.failedTasks.load(std::memory_order_relaxed);
// This task has already finished running, but Complete(task) has not yet updated the counters.
// Include the current task in the local progress snapshot so the logged remaining count is accurate.
const uint64_t doneIncludingCurrent = (done < total) ? (done + 1) : total;
const uint64_t remaining = (total > doneIncludingCurrent) ? (total - doneIncludingCurrent) : 0;

// Proxy for permutation complexity: descriptor low 32 bits from GetId(); popcount = active defines.
// Shader file size provides a secondary signal for source complexity.
Expand Down
Loading