Skip to content

ci: bump actions to node24 to clear deprecation warnings #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 1 commit into from
May 3, 2026
Merged

ci: bump actions to node24 to clear deprecation warnings #2273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/actions/setup-build-environment/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,13 @@ runs:
Remove-Item $installerPath -ErrorAction SilentlyContinue

- name: Setup MSVC environment
uses: ilammy/msvc-dev-cmd@v1
# Swapped from ilammy/msvc-dev-cmd@v1 (node20, deprecated) to
# TheMrMilchmann/setup-msvc-dev@v4 (node24). The new action has no
# `vsversion` input — the prior step installs only VS Build Tools
# 2026, so default detection picks it up.
uses: TheMrMilchmann/setup-msvc-dev@v4.0.0
with:
arch: x64
vsversion: "18.0"

- name: Get MSVC version
id: msvc_version
Expand Down Expand Up @@ -85,12 +88,12 @@ runs:
Remove-Item "dummy.cpp" -ErrorAction SilentlyContinue

- name: Setup vcpkg
uses: lukka/run-vcpkg@v11.5
uses: lukka/run-vcpkg@v11.6
with:
vcpkgJsonGlob: vcpkg.json

- name: Cache CMake build output
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: ${{ inputs.build-dir }}
key: ${{ runner.os }}-cmake-msvc-${{ steps.msvc_version.outputs.version }}-${{ inputs.cache-key-suffix }}-${{ github.event.inputs.cache-key-suffix || 'default' }}-${{ hashFiles('.gitmodules', 'extern/**', 'CMakePresets.json', 'vcpkg.json', 'vcpkg-configuration.json') }}
Expand Down
Loading