Skip to content

ci: add choice dropdowns for workflows#2264

Merged
alandtse merged 1 commit into
community-shaders:devfrom
alandtse:ci/workflow-dropdowns
May 2, 2026
Merged

ci: add choice dropdowns for workflows#2264
alandtse merged 1 commit into
community-shaders:devfrom
alandtse:ci/workflow-dropdowns

Conversation

@alandtse
Copy link
Copy Markdown
Collaborator

@alandtse alandtse commented May 2, 2026

Summary

  • Release: Semantic Versionrelease_type is now a type: choice dropdown (rc / stable, default rc) instead of a free-text box. Prevents silent fallback to RC if someone types Stable or stable with a typo.
  • Nexus: Upload Releasedry_run is now a type: choice dropdown (true / false, default true) instead of a free-text box. Makes the safe default obvious.

The workflow_call declaration for dry_run remains type: string (GitHub doesn't support choice there). The normalization step (if [ "$INPUT_DRY_RUN" = "false" ]) is unchanged and handles both values correctly.

Test plan

  • Confirm dropdowns render correctly in the Actions UI

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD workflow configuration with improved input validation for deployment and release processes, ensuring more reliable automation.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 40824e40-aa38-48e2-95a6-8343f559efd4

📥 Commits

Reviewing files that changed from the base of the PR and between 4e390e7 and fd99fd3.

📒 Files selected for processing (2)
  • .github/workflows/nexus-upload.yaml
  • .github/workflows/release-semantic.yaml

📝 Walkthrough

Walkthrough

Two GitHub Actions workflows are updated to enforce input type safety by converting untyped string inputs to typed choice inputs with explicit option constraints: nexus-upload.yaml constrains dry_run to ["true", "false"], and release-semantic.yaml constrains release_type to ["rc", "stable"].

Changes

Nexus Upload Workflow

Layer / File(s) Summary
Input Type Constraint
.github/workflows/nexus-upload.yaml
dry_run input converted from untyped string to choice type with explicit options: ["true", "false"] and default: "true", enforcing valid values at workflow dispatch.

Release Semantic Workflow

Layer / File(s) Summary
Input Type Constraint
.github/workflows/release-semantic.yaml
release_type input converted from plain input to choice type with explicit options: ["rc", "stable"], simplified description, maintaining required: true and default: "rc".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • doodlum
  • SkrubbySkrubInAShrub

Poem

🐰 A rabbit's ode to typed inputs, true
Choice fields now guard what users do,
No more loose strings in workflows' flight,
Just "true" or "false"—constrained, tight.
Release types safe in "rc" or "stable" sight! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding choice-type dropdowns for workflow_dispatch inputs (release_type and dry_run) in GitHub Actions workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 actionlint (1.7.12)
.github/workflows/nexus-upload.yaml

could not read ".github/workflows/nexus-upload.yaml": open .github/workflows/nexus-upload.yaml: no such file or directory

.github/workflows/release-semantic.yaml

could not read ".github/workflows/release-semantic.yaml": open .github/workflows/release-semantic.yaml: no such file or directory

🔧 YAMLlint (1.38.0)
.github/workflows/nexus-upload.yaml

[Errno 2] No such file or directory: '.github/workflows/nexus-upload.yaml'

.github/workflows/release-semantic.yaml

[Errno 2] No such file or directory: '.github/workflows/release-semantic.yaml'

🔧 Checkov (3.2.525)
.github/workflows/nexus-upload.yaml

2026-05-02 10:09:15,338 [MainThread ] [ERROR] Template file not found: .github/workflows/nexus-upload.yaml
2026-05-02 10:09:15,342 [MainThread ] [ERROR] Template file not found: .github/workflows/nexus-upload.yaml
2026-05-02 10:09:15,365 [MainThread ] [ERROR] Template file not found: .github/workflows/nexus-upload.yaml
2026-05-02 10:09:15,380 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with .github/workflows/nexus-upload.yaml
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)

... [truncated 9182 characters] ...

not process file .github/workflows/nexus-upload.yaml
2026-05-02 10:09:15,418 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: '.github/workflows/nexus-upload.yaml'

.github/workflows/release-semantic.yaml

2026-05-02 10:09:15,338 [MainThread ] [ERROR] Template file not found: .github/workflows/release-semantic.yaml
2026-05-02 10:09:15,342 [MainThread ] [ERROR] Template file not found: .github/workflows/release-semantic.yaml
2026-05-02 10:09:15,370 [MainThread ] [ERROR] Template file not found: .github/workflows/release-semantic.yaml
2026-05-02 10:09:15,374 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with .github/workflows/release-semantic.yaml
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)

... [truncated 9250 characters] ...

ess file .github/workflows/release-semantic.yaml
2026-05-02 10:09:15,410 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: '.github/workflows/release-semantic.yaml'


Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

No actionable suggestions for changed features.

@alandtse alandtse changed the title ci: add choice dropdowns for release_type and dry_run inputs ci: add choice dropdowns for workflows May 2, 2026
@alandtse alandtse merged commit e9ee125 into community-shaders:dev May 2, 2026
13 checks passed
@alandtse alandtse deleted the ci/workflow-dropdowns branch May 2, 2026 10:11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

✅ A pre-release build is available for this PR:
Download

ParticleTroned added a commit to ParticleTroned/skyrim-community-shaders that referenced this pull request May 15, 2026
ParticleTroned added a commit to ParticleTroned/skyrim-community-shaders that referenced this pull request May 16, 2026
IgorAlanAlbuquerque pushed a commit to IgorAlanAlbuquerque/skyrim-community-shaders that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant