ci: add choice dropdowns for workflows#2264
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo GitHub Actions workflows are updated to enforce input type safety by converting untyped string inputs to typed ChangesNexus Upload Workflow
Release Semantic Workflow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 actionlint (1.7.12).github/workflows/nexus-upload.yamlcould not read ".github/workflows/nexus-upload.yaml": open .github/workflows/nexus-upload.yaml: no such file or directory .github/workflows/release-semantic.yamlcould not read ".github/workflows/release-semantic.yaml": open .github/workflows/release-semantic.yaml: no such file or directory 🔧 YAMLlint (1.38.0).github/workflows/nexus-upload.yaml[Errno 2] No such file or directory: '.github/workflows/nexus-upload.yaml' .github/workflows/release-semantic.yaml[Errno 2] No such file or directory: '.github/workflows/release-semantic.yaml' 🔧 Checkov (3.2.525).github/workflows/nexus-upload.yaml2026-05-02 10:09:15,338 [MainThread ] [ERROR] Template file not found: .github/workflows/nexus-upload.yaml ... [truncated 9182 characters] ... not process file .github/workflows/nexus-upload.yaml .github/workflows/release-semantic.yaml2026-05-02 10:09:15,338 [MainThread ] [ERROR] Template file not found: .github/workflows/release-semantic.yaml ... [truncated 9250 characters] ... ess file .github/workflows/release-semantic.yaml Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
|
No actionable suggestions for changed features. |
|
✅ A pre-release build is available for this PR: |
Summary
Release: Semantic Version—release_typeis now atype: choicedropdown (rc/stable, defaultrc) instead of a free-text box. Prevents silent fallback to RC if someone typesStableorstablewith a typo.Nexus: Upload Release—dry_runis now atype: choicedropdown (true/false, defaulttrue) instead of a free-text box. Makes the safe default obvious.The
workflow_calldeclaration fordry_runremainstype: string(GitHub doesn't supportchoicethere). The normalization step (if [ "$INPUT_DRY_RUN" = "false" ]) is unchanged and handles both values correctly.Test plan
Summary by CodeRabbit