Skip to content

refactor(volumetric-lighting): use constant for threshold #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 2 commits into from
May 3, 2026
+2 −1
Merged

refactor(volumetric-lighting): use constant for threshold #2257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ed0e5
Update ISApplyVolumetricLighting.hlsl
davo0411 May 2, 2026
5406b08
Update package/Shaders/ISApplyVolumetricLighting.hlsl
davo0411 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package/Shaders/ISApplyVolumetricLighting.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ cbuffer PerGeometry : register(b2)
PS_OUTPUT main(PS_INPUT input)
{
PS_OUTPUT psout;
static const float kVLThresholdBias = 1.0 / 128.0;
Comment thread
alandtse marked this conversation as resolved.

float2 screenPosition = FrameBuffer::GetDynamicResolutionAdjustedScreenPosition(input.TexCoord);
float depth = DepthTex.Sample(DepthSampler, screenPosition).x;
Expand All @@ -49,7 +50,7 @@ PS_OUTPUT main(PS_INPUT input)

float noiseGrad = 0.03125 * NoiseGradSamplerTex.Sample(NoiseGradSamplerSampler, 0.125 * input.Position.xy).x;

float adjustedVl = max(0, noiseGrad + vl - 0.0078125);
float adjustedVl = max(0.0, noiseGrad + vl - kVLThresholdBias);

if (0.001 < g_IntensityX_TemporalY.y) {
float2 motionVector = MotionVectorsTex.Sample(MotionVectorsSampler, screenPosition).xy;
Expand Down
Loading