Skip to content

feat(HDR): warn users when in exclusive fullscreen #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davo0411 merged 3 commits into from
Apr 23, 2026
Merged

feat(HDR): warn users when in exclusive fullscreen #2187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dddbade
feat(HDR): warn users when in exclusive fullscreen
Apr 22, 2026
fbc885b
style: 🎨 apply pre-commit.ci formatting
pre-commit-ci[bot] Apr 22, 2026
a941d98
fix: AI comment
Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Features/HDRDisplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ namespace
}

bool HDRDisplay::isHDRMonitor = false;
bool HDRDisplay::wasExclusiveFullscreen = false;

bool HDRDisplay::DetectHDR()
{
Expand Down Expand Up @@ -278,6 +279,18 @@ void HDRDisplay::DrawSettings()
} else {
ImGui::TextColored(Util::Colors::GetWarning(), "SDR Display (HDR not detected)");
}

const bool isExclusiveFullscreen = globals::features::upscaling.loaded ? !globals::features::upscaling.isWindowed : wasExclusiveFullscreen;

if (isExclusiveFullscreen) {
ImGui::Spacing();
ImGui::PushStyleColor(ImGuiCol_Text, Util::Colors::GetWarning());
ImGui::TextWrapped("WARNING: Exclusive Fullscreen detected.");
ImGui::TextWrapped("HDR is not compatible with Exclusive Fullscreen and may not work correctly. Switch to Borderless Windowed mode for proper HDR support.");
ImGui::PopStyleColor();
ImGui::Spacing();
}

ImGui::Spacing();

// Gate HDR checkbox behind monitor detection
Expand Down
1 change: 1 addition & 0 deletions src/Features/HDRDisplay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ struct HDRDisplay : public Feature

static bool DetectHDR();
static bool isHDRMonitor;
static bool wasExclusiveFullscreen; // EFS detected at swapchain creation; incompatible with HDR
bool pendingAutoDetect = false;

float GetDisplayMaxLuminance() const;
Expand Down
3 changes: 3 additions & 0 deletions src/Hooks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,9 @@ HRESULT WINAPI hk_D3D11CreateDeviceAndSwapChain(
modifiedDesc.SwapEffect = DXGI_SWAP_EFFECT_FLIP_DISCARD;
if (modifiedDesc.BufferCount < 2)
modifiedDesc.BufferCount = 2;

HDRDisplay::wasExclusiveFullscreen = !modifiedDesc.Windowed;

logger::info("[HDR] Upgraded swap chain: R10G10B10A2_UNORM + FLIP_DISCARD");
}

Expand Down
Loading