Skip to content

refactor(weather-editor): remove duplicate code #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlum merged 2 commits into from
Apr 20, 2026
Merged

refactor(weather-editor): remove duplicate code #2154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04b6aef
chore: remove duplicate code
Apr 19, 2026
d553deb
chore: remove redundant block scope
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions src/WeatherEditor/Weather/PrecipitationWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,28 +75,21 @@ void PrecipitationWidget::DrawWidget()
}

ImGui::SeparatorText("Texture Path");
if (ImGui::InputText("Particle Texture", textureBuffer, sizeof(textureBuffer))) {
std::string_view buf(textureBuffer);
if (buf != lastCheckedBuffer) {
lastCheckedExists = WeatherUtils::TexturePath::ExistsOnDisk(buf);
lastCheckedBuffer = std::string(buf);
}
if (lastCheckedExists) {
settings.particleTexture = lastCheckedBuffer;
changed = true;
}
const bool inputChanged = ImGui::InputText("Particle Texture", textureBuffer, sizeof(textureBuffer));
std::string_view buf(textureBuffer);
if (buf != lastCheckedBuffer) {
lastCheckedBuffer = std::string(buf);
lastCheckedExists = WeatherUtils::TexturePath::ExistsOnDisk(buf);
}
if (std::string_view buf(textureBuffer); settings.particleTexture != buf) {
if (!buf.empty() && !WeatherUtils::TexturePath::HasDdsExtension(buf))
if (inputChanged && lastCheckedExists) {
settings.particleTexture = lastCheckedBuffer;
changed = true;
}
if (settings.particleTexture != buf && !buf.empty()) {
if (!WeatherUtils::TexturePath::HasDdsExtension(buf))
ImGui::TextColored(globals::menu->GetTheme().StatusPalette.Error, "Path must end with '.dds'");
else if (!buf.empty()) {
if (buf != lastCheckedBuffer) {
lastCheckedExists = WeatherUtils::TexturePath::ExistsOnDisk(buf);
lastCheckedBuffer = std::string(buf);
}
if (!lastCheckedExists)
ImGui::TextColored(globals::menu->GetTheme().StatusPalette.Error, "Texture file not found under Data/textures/.");
}
else if (!lastCheckedExists)
ImGui::TextColored(globals::menu->GetTheme().StatusPalette.Error, "Texture file not found under Data/textures/.");
}

EndScrollableContent();
Expand Down
Loading