Skip to content

refactor(weather-editor): use existing functions for lock retarget #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 3 commits into from
Apr 20, 2026
Merged

refactor(weather-editor): use existing functions for lock retarget #2153

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9de94bb
chore: use existing functions
Apr 19, 2026
afe48d5
Merge branch 'dev' into fix/WE-weather-lock-retarget
SkrubbySkrubInAShrub Apr 19, 2026
bbe0ca4
Merge branch 'dev' into fix/WE-weather-lock-retarget
alandtse Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/Features/WeatherEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,11 +685,9 @@ void WeatherEditor::RenderWeatherControls(RE::Sky* sky)
else
sky->SetWeather(selectedWeather, true, false);

// If the lock is active, retarget it to the newly chosen weather so
// Prepass() enforces the new choice instead of reverting it.
if (editorWindow->IsWeatherLocked()) {
editorWindow->lockedWeather = selectedWeather;
}
// Retarget the lock so Prepass() enforces the new choice instead of reverting it.
if (editorWindow->IsWeatherLocked())
editorWindow->LockWeather(selectedWeather);

Util::ClearComboSearch(kWeatherSearchId);
logger::info("[WeatherEditor] Changed weather to: {}", Util::FormatWeather(selectedWeather));
Expand Down
Loading