chore(weather-widget): remove unused code

[SkrubbySkrubInAShrub]

removed leftover code that was never removed since the design stage.

Summary by CodeRabbit

• Refactor
  • Simplified weather settings structure by removing per-time-of-day image-space parameters (HDR, cinematic, tint, and depth-of-field settings) from the weather widget configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d4d15ab3-9232-4114-8dd8-9508148f6c4d

📥 Commits

Reviewing files that changed from the base of the PR and between 31a7b55 and f34f7a7.

📒 Files selected for processing (2)

• src/WeatherEditor/Weather/WeatherWidget.cpp
• src/WeatherEditor/Weather/WeatherWidget.h

💤 Files with no reviewable changes (2)

• src/WeatherEditor/Weather/WeatherWidget.h
• src/WeatherEditor/Weather/WeatherWidget.cpp

---

📝 Walkthrough

Walkthrough

The PR removes image-space settings functionality from the WeatherWidget, including the ImageSpaceSettings struct definition, JSON serialization bindings, the imageSpaces member variable, and updates the equality operator to exclude image-space comparisons.

Changes

Cohort / File(s)	Summary
ImageSpaceSettings Removal src/WeatherEditor/Weather/WeatherWidget.h	Deleted ImageSpaceSettings struct definition and removed Settings::imageSpaces member array.
Serialization & Equality Updates src/WeatherEditor/Weather/WeatherWidget.cpp	Removed NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE binding for ImageSpaceSettings and updated Settings::operator== to exclude imageSpaces comparison.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat(weather editor): repurpose unsaved changes tracking #1860: Adds ImageSpaceSettings equality tracking and includes imageSpaces in Settings comparisons/serialization, which this PR removes in reverse.

Suggested reviewers

• doodlum
• davo0411

Poem

🐰 Image spaces fade away,
No more HDR tints to say,
Settings lean and trim so bright,
WeatherWidget feels just right! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing unused ImageSpaceSettings code from the weather widget that was leftover from the design stage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download