build: bump renderdoc to 1.43#2115
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughBumped RenderDoc from 1.40 → 1.43 in port and feature docs; updated vendored REF and SHA512; replaced generic runtime download link with a stable Windows ZIP URL template; advanced RenderDoc API declarations and usage to RENDERDOC_API_1_7_0; updated LICENSE year to 2026. Changes
Sequence Diagram(s)(No sequence diagrams generated — changes are version/docs/API updates without new multi-component control flow.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No actionable suggestions for changed features. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
cmake/ports/renderdoc/portfile.cmake (1)
26-26: Refresh the template example version literal.The comment example still uses
1.40, which is stale after this bump and can mislead copy-paste users.Proposed comment tweak
-# set(RENDERDOC_VERSION 1.40) +# set(RENDERDOC_VERSION 1.43)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmake/ports/renderdoc/portfile.cmake` at line 26, Update the example comment that sets RENDERDOC_VERSION to match the bumped release: change the commented line "# set(RENDERDOC_VERSION 1.40)" to use the current RENDERDOC_VERSION value used in this portfile (replace "1.40" with the actual bumped version string) so copy-paste users get the correct example.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@features/RenderDoc/Renderdoc/README.md`:
- Around line 13-19: Update the README to consistently reflect the new stable
ZIP URL flow: replace references to "MSI", "builds" or phrases implying MSI
installers with wording that references the stable ZIP downloads (e.g., the URL
pattern `https://renderdoc.org/stable/${VERSION}/RenderDoc_${VERSION}_64.zip`
and "stable ZIP" or "ZIP archive"), and update any downstream instructions that
mention installing or using an MSI to instead explain extracting/using the ZIP
(look for occurrences of "MSI", "builds", or "installer" in the Renderdoc README
and adjust the examples and steps accordingly).
---
Nitpick comments:
In `@cmake/ports/renderdoc/portfile.cmake`:
- Line 26: Update the example comment that sets RENDERDOC_VERSION to match the
bumped release: change the commented line "# set(RENDERDOC_VERSION 1.40)" to
use the current RENDERDOC_VERSION value used in this portfile (replace "1.40"
with the actual bumped version string) so copy-paste users get the correct
example.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 47a3f65a-0ccf-4014-b374-9ccc81458c80
⛔ Files ignored due to path filters (1)
features/RenderDoc/Renderdoc/renderdoc.dllis excluded by!**/*.dll
📒 Files selected for processing (6)
cmake/ports/renderdoc/README.mdcmake/ports/renderdoc/portfile.cmakecmake/ports/renderdoc/vcpkg.jsonfeatures/RenderDoc/README.mdfeatures/RenderDoc/Renderdoc/LICENSE.mdfeatures/RenderDoc/Renderdoc/README.md
💤 Files with no reviewable changes (1)
- features/RenderDoc/README.md
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Features/RenderDoc.h`:
- Line 17: The declaration and requested RenderDoc API version are inconsistent:
update the requested version in the initialization to match the declared
interface type or change the declaration to match the requested version;
specifically, ensure the struct type RENDERDOC_API_1_7_0 used for the pointer
renderDocApi matches the enum passed (e.g., replace eRENDERDOC_API_Version_1_6_0
with the corresponding eRENDERDOC_API_Version_1_7_0 in the initialization in
RenderDoc.cpp or rename the struct/typedef to 1_6_0 to match the existing
initialization) so the runtime interface table layout is compatible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0d4c3243-1703-4d1c-915d-0d23202ffb69
📒 Files selected for processing (1)
src/Features/RenderDoc.h
|
✅ A pre-release build is available for this PR: |
doodlum
approved these changes
Apr 14, 2026
YtzyFvra
pushed a commit
to YtzyFvra/skyrim-community-shaders
that referenced
this pull request
Apr 19, 2026
ParticleTroned
pushed a commit
to ParticleTroned/skyrim-community-shaders
that referenced
this pull request
May 2, 2026
(cherry picked from commit 4c55cc7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Documentation