docs: update in game links#2055
Conversation
📝 WalkthroughWalkthroughA single file modification updating UI labels and links in the home page renderer. Button labels were simplified ("GitHub Repository" → "GitHub", "GitHub Wiki" → "Wiki"), a new "Developer Wiki" button was added, and an FAQ answer about failed shader compilation was condensed with updated guidance. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No actionable suggestions for changed features. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/Menu/HomePageRenderer.cpp (1)
159-181:⚠️ Potential issue | 🟠 MajorLayout calculation mismatch: 4 buttons but width calculated for 3.
The
totalWidthcalculation on line 160 usesbuttonWidth * 3 + ImGui::GetStyle().ItemSpacing.x * 2, but there are now 4 buttons in the row (Nexus Mods, GitHub, Wiki, Developer Wiki). This will cause the button row to be off-center.🐛 Proposed fix
// Center the button layout float buttonWidth = QUICK_LINKS_BUTTON_WIDTH * Util::GetUIScale(); - float totalWidth = buttonWidth * 3 + ImGui::GetStyle().ItemSpacing.x * 2; // 3 buttons with spacing + float totalWidth = buttonWidth * 4 + ImGui::GetStyle().ItemSpacing.x * 3; // 4 buttons with spacing ImGui::SetCursorPosX((windowSize.x - totalWidth) * 0.5f);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Menu/HomePageRenderer.cpp` around lines 159 - 181, Update the centering math to match the actual number of buttons: change the totalWidth calculation that uses buttonWidth and ImGui::GetStyle().ItemSpacing.x so it accounts for 4 buttons and 3 spacings (e.g., totalWidth = buttonWidth * 4 + ImGui::GetStyle().ItemSpacing.x * 3). Locate the variables buttonWidth and totalWidth and the ImGui::SetCursorPosX call in HomePageRenderer.cpp (the block with the ImGui::Button calls "Nexus Mods", "GitHub", "Wiki", "Developer Wiki") and replace the old 3-button formula with the 4-button formula so the row centers correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/Menu/HomePageRenderer.cpp`:
- Around line 159-181: Update the centering math to match the actual number of
buttons: change the totalWidth calculation that uses buttonWidth and
ImGui::GetStyle().ItemSpacing.x so it accounts for 4 buttons and 3 spacings
(e.g., totalWidth = buttonWidth * 4 + ImGui::GetStyle().ItemSpacing.x * 3).
Locate the variables buttonWidth and totalWidth and the ImGui::SetCursorPosX
call in HomePageRenderer.cpp (the block with the ImGui::Button calls "Nexus
Mods", "GitHub", "Wiki", "Developer Wiki") and replace the old 3-button formula
with the 4-button formula so the row centers correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a7e5fa50-d903-4be7-ab02-8076693a403a
📒 Files selected for processing (1)
src/Menu/HomePageRenderer.cpp
|
✅ A pre-release build is available for this PR: |
(cherry picked from commit 8a6c4ba)
Very minor UI text changes on the home page.
A user on Nexus recently read some outdated information on the GitHub wiki, which is no longer maintained for user support. This PR adds a link to the newer Modding.wiki Wiki. Though fundamentally the issue is probably the fact that the wiki links on the official Nexus page still point to GitHub.
Also changed the FAQ for
Failed Shaderswhich is sort of outdated now since the list is larger now. To avoid having to continuously maintain it, I've just made it a generic message which points to where they need to look for information.Summary by CodeRabbit