feat(ui): add Sky Sync tooltips; fix overlay resizing

[soda3000]

Summary by CodeRabbit

• New Features
  • Added hover tooltips to Sky Sync settings controls, including the Enabled checkbox, alternate sun path option, sun path and custom angle sliders, moon light source slider, and sun position offset sliders for enhanced user guidance.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR modifies UI overlay behavior in two files: it removes the ImGuiWindowFlags_AlwaysAutoResize flag from the performance overlay window configuration, and adds hover tooltip text wrapping to multiple sun and moon position controls in the SkySync settings UI.

Changes

Cohort / File(s)	Summary
Performance Overlay src/Features/PerformanceOverlay.cpp	Removed ImGuiWindowFlags_AlwaysAutoResize flag from the overlay window, leaving only ImGuiWindowFlags_NoDecoration as the base flag configuration.
SkySync Tooltips src/Features/SkySync.cpp	Added Util::HoverTooltipWrapper() calls wrapping hover text for multiple UI controls: the "Enabled" checkbox, "Use alternate sun path" option, "Sun path" slider, "Custom angle" slider, "Moon light source" slider, and four "Sun Position Offsets" sliders (sunrise/sunset begin/end).

Possibly related PRs

• feat(perf-overlay): add size controls #1591: Directly modifies PerformanceOverlay::DrawOverlay window flags and ImGuiWindowFlags_AlwaysAutoResize behavior.
• feat(sky-sync): add sun offset and MinElevation sliders #1691: Introduces sun offset controls and related SkySync UI elements that are now enhanced with tooltips in this PR.
• refactor(ui): update general settings layout, add tooltip delay setting #1235: Modifies Util::HoverTooltipWrapper() behavior and tooltip settings that are extensively used in these changes.

Suggested reviewers

• alandtse
• davo0411

Poem

🐰 A tooltip here, a flag removed there,
The UI gets dressed with extra care!
Sun paths shine with helpful text,
No more guessing what comes next!
✨🌙☀️

---

Estimated code review effort: 🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the two main changes: adding tooltips to Sky Sync UI and fixing Performance Overlay resizing behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[coderabbitai]

🧹 Nitpick comments (1)

src/Features/SkySync.cpp (1)

19-72: Consider consolidating repeated tooltip blocks with a local helper.

This section repeats the same HoverTooltipWrapper pattern many times; a tiny local helper would reduce copy/paste drift.

♻️ Optional cleanup example

 void SkySync::DrawSettings()
 {
+	auto drawTooltip = [](const char* text) {
+		if (auto _tt = Util::HoverTooltipWrapper())
+			ImGui::TextUnformatted(text);
+	};
+
 	ImGui::Checkbox("Enabled", &settings.Enabled);
-	if (auto _tt = Util::HoverTooltipWrapper()) {
-		ImGui::TextUnformatted("Enable or disable Sky Sync features.");
-	}
+	drawTooltip("Enable or disable Sky Sync features.");

 	ImGui::Checkbox("Use alternate sun path", &settings.UseAlternateSunPath);
-	if (auto _tt = Util::HoverTooltipWrapper()) {
-		ImGui::TextUnformatted("Calculate sun position based on time of day and season instead of vanilla movement.");
-	}
+	drawTooltip("Calculate sun position based on time of day and season instead of vanilla movement.");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Features/SkySync.cpp` around lines 19 - 72, The UI code repeatedly calls
Util::HoverTooltipWrapper followed by ImGui::TextUnformatted/Text, so introduce
a small local helper (lambda or static inline function) inside the function that
renders this panel—e.g., a helper named ShowTooltip(const char* msg) that wraps
the pattern (if (auto _tt = Util::HoverTooltipWrapper())
ImGui::TextUnformatted(msg);) and then replace each direct
Util::HoverTooltipWrapper block (the occurrences around "Enable or disable Sky
Sync features.", "Calculate sun position...", "Choose the trajectory...", "Set a
custom angle...", "Select which moon...", and all sunrise/sunset tooltip
strings) with calls to ShowTooltip; keep special-case ImGui::Text calls by using
the same helper or adding an overload for formatted text if needed, and leave
SetSunAngle(), settings.* and ImGui widgets unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/Features/SkySync.cpp`:
- Around line 19-72: The UI code repeatedly calls Util::HoverTooltipWrapper
followed by ImGui::TextUnformatted/Text, so introduce a small local helper
(lambda or static inline function) inside the function that renders this
panel—e.g., a helper named ShowTooltip(const char* msg) that wraps the pattern
(if (auto _tt = Util::HoverTooltipWrapper()) ImGui::TextUnformatted(msg);) and
then replace each direct Util::HoverTooltipWrapper block (the occurrences around
"Enable or disable Sky Sync features.", "Calculate sun position...", "Choose the
trajectory...", "Set a custom angle...", "Select which moon...", and all
sunrise/sunset tooltip strings) with calls to ShowTooltip; keep special-case
ImGui::Text calls by using the same helper or adding an overload for formatted
text if needed, and leave SetSunAngle(), settings.* and ImGui widgets unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b1e98e07-1608-45d4-adcf-63d960ab9dd0

📥 Commits

Reviewing files that changed from the base of the PR and between d158508 and 2fe351f.

📒 Files selected for processing (2)

• src/Features/PerformanceOverlay.cpp
• src/Features/SkySync.cpp

[github-actions]

✅ A pre-release build is available for this PR:
Download

[alandtse]

Please make atomic prs.