Skip to content

refactor: use ini file for meta data #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alandtse wants to merge 1 commit into from
Closed

refactor: use ini file for meta data #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions features/Cloud Shadows/Shaders/Features/CloudShadows.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-2-0
[Info]
Version = 1-2-0
NexusFileGroupID =
NexusModID = 139185
4 changes: 3 additions & 1 deletion features/Dynamic Cubemaps/Shaders/Features/DynamicCubemaps.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 2-3-0
Version = 2-3-0
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Exponential Height Fog/Shaders/Features/ExponentialHeightFog.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-0
[Info]
Version = 1-0-0
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Extended Materials/Shaders/Features/ExtendedMaterials.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-1
[Info]
Version = 1-1-1
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Extended Translucency/Shaders/Features/ExtendedTranslucency.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-0
[Info]
Version = 1-0-0
NexusFileGroupID = 6156484
NexusModID = 150755
4 changes: 3 additions & 1 deletion features/Grass Collision/Shaders/Features/GrassCollision.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 3-0-3
Version = 3-0-3
NexusFileGroupID =
NexusModID = 87816
4 changes: 3 additions & 1 deletion features/Grass Lighting/Shaders/Features/GrassLighting.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 2-0-1
Version = 2-0-1
NexusFileGroupID = 3119146
NexusModID = 86502
4 changes: 3 additions & 1 deletion features/Hair Specular/Shaders/Features/HairSpecular.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
Version = 1-1-0
NexusFileGroupID =
NexusModID = 149011
4 changes: 3 additions & 1 deletion features/IBL/Shaders/Features/ImageBasedLighting.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
Version = 1-1-0
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Interior Sun/Shaders/Features/InteriorSun.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-0
[Info]
Version = 1-0-0
NexusFileGroupID =
NexusModID = 153541
6 changes: 4 additions & 2 deletions features/Inverse Square Lighting/Shaders/Features/InverseSquareLighting.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-2-0
[Info]
Version = 1-2-0
NexusFileGroupID =
NexusModID = 153542
6 changes: 4 additions & 2 deletions features/LOD Blending/Shaders/Features/LODBlending.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-0
[Info]
Version = 1-0-0
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Light Limit Fix/Shaders/Features/LightLimitFix.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 3-0-2
[Info]
Version = 3-0-2
NexusFileGroupID = 3150964
NexusModID = 99548
4 changes: 3 additions & 1 deletion features/Linear Lighting/Shaders/Features/LinearLighting.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
Version = 1-1-0
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Performance Overlay/Shaders/Features/PerformanceOverlay.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-1
[Info]
Version = 1-0-1
NexusFileGroupID =
NexusModID =
4 changes: 3 additions & 1 deletion features/RenderDoc/Shaders/Features/RenderDoc.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-0
Version = 1-0-0
NexusFileGroupID =
NexusModID =
4 changes: 3 additions & 1 deletion features/Screen Space GI/Shaders/Features/ScreenSpaceGI.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 4-1-0
Version = 4-1-0
NexusFileGroupID =
NexusModID = 130375
4 changes: 3 additions & 1 deletion features/Screen-Space Shadows/Shaders/Features/ScreenSpaceShadows.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 2-1-0
Version = 2-1-0
NexusFileGroupID = 3138904
NexusModID = 93209
4 changes: 3 additions & 1 deletion features/Sky Sync/Shaders/Features/SkySync.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-1
Version = 1-0-1
NexusFileGroupID =
NexusModID = 153543
4 changes: 3 additions & 1 deletion features/Skylighting/Shaders/Features/Skylighting.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-2-4
Version = 1-2-4
NexusFileGroupID =
NexusModID = 139352
6 changes: 4 additions & 2 deletions features/Subsurface Scattering/Shaders/Features/SubsurfaceScattering.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 3-0-1
[Info]
Version = 3-0-1
NexusFileGroupID =
NexusModID = 114114
4 changes: 3 additions & 1 deletion features/Terrain Blending/Shaders/Features/TerrainBlending.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-2
Version = 1-0-2
NexusFileGroupID =
NexusModID = 157076
6 changes: 4 additions & 2 deletions features/Terrain Helper/Shaders/Features/TerrainHelper.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-0
[Info]
Version = 1-0-0
NexusFileGroupID =
NexusModID = 143149
4 changes: 3 additions & 1 deletion features/Terrain Shadows/Shaders/Features/TerrainShadows.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
Version = 1-1-0
NexusFileGroupID =
NexusModID = 135817
6 changes: 4 additions & 2 deletions features/Terrain Variation/Shaders/Features/TerrainVariation.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-1
[Info]
Version = 1-0-1
NexusFileGroupID =
NexusModID = 148123
4 changes: 3 additions & 1 deletion features/Unified Water/Shaders/Features/UnifiedWater.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-0-1
Version = 1-0-1
NexusFileGroupID =
NexusModID =
4 changes: 3 additions & 1 deletion features/Upscaling/Shaders/Features/Upscaling.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-3-0
Version = 1-3-0
NexusFileGroupID =
NexusModID = 156952
4 changes: 3 additions & 1 deletion features/VR/Shaders/Features/VR.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
Version = 1-1-0
NexusFileGroupID =
NexusModID =
4 changes: 3 additions & 1 deletion features/Volumetric Lighting/Shaders/Features/VolumetricLighting.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
Version = 1-1-0
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Volumetric Shadows/Shaders/Features/VolumetricShadows.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 2-0-0
[Info]
Version = 2-0-0
NexusFileGroupID =
NexusModID =
6 changes: 4 additions & 2 deletions features/Water Effects/Shaders/Features/WaterEffects.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
[Info]
Version = 1-1-0
NexusFileGroupID =
NexusModID = 112762
4 changes: 3 additions & 1 deletion features/Weather Editor/Shaders/Features/WeatherEditor.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 1-1-0
Version = 1-1-0
NexusFileGroupID =
NexusModID =
4 changes: 3 additions & 1 deletion features/Wetness Effects/Shaders/Features/WetnessEffects.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[Info]
Version = 3-1-0
Version = 3-1-0
NexusFileGroupID = 3176515
NexusModID = 112739
6 changes: 6 additions & 0 deletions src/Feature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ void Feature::Load(json& o_json)
return;
}

// Read Nexus metadata (populated regardless of version compatibility)
if (auto nexusId = ini.GetValue("Info", "NexusModID"); nexusId && *nexusId)
nexusModID = nexusId;
if (auto nexusFileGroup = ini.GetValue("Info", "NexusFileGroupID"); nexusFileGroup && *nexusFileGroup)
nexusFileGroupID = nexusFileGroup;

bool hasError = false;
std::string errorVersion;
FeatureIssues::FeatureIssueInfo::IssueType errorType = FeatureIssues::FeatureIssueInfo::IssueType::UNKNOWN;
Expand Down
4 changes: 3 additions & 1 deletion src/Feature.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,13 @@ struct Feature
static constexpr std::string_view NEXUS_BASE_URL = "https://www.nexusmods.com/skyrimspecialedition/mods/";
bool loaded = false;
std::string version;
std::string nexusModID;
std::string nexusFileGroupID;
std::string failedLoadedMessage;

virtual std::string GetName() = 0;
virtual std::string GetShortName() = 0;
virtual std::string GetFeatureModLink() { return ""; }
virtual std::string GetFeatureModLink() { return nexusModID.empty() ? "" : MakeNexusModURL(nexusModID); }
virtual std::string_view GetShaderDefineName() { return ""; }
virtual std::vector<std::pair<std::string_view, std::string_view>> GetShaderDefineOptions() { return {}; }

Expand Down
Loading
Loading