Skip to content

chore: bump versions #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davo0411 merged 2 commits into from
Mar 24, 2026
+2 −2
Merged

chore: bump versions #2010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c32d242
chore: bump versions
Mar 24, 2026
698c7b4
Merge branch 'dev' into bump-ver
SkrubbySkrubInAShrub Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/Inverse Square Lighting/Shaders/Features/InverseSquareLighting.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[Info]
Version = 1-1-0
Version = 1-2-0
2 changes: 1 addition & 1 deletion features/Performance Overlay/Shaders/Features/PerformanceOverlay.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[Info]
Version = 1-0-0
Version = 1-0-1
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if cmake/FeatureVersions.h.in or generated headers reference the new versions
rg -n "PerformanceOverlay|InverseSquareLighting" cmake/ src/ -A2 -B2

Repository: doodlum/skyrim-community-shaders

Length of output: 30223

🏁 Script executed:

#!/bin/bash
# Find version-related files and mappings
fd -t f ".*Version.*\|.*version.*" cmake/ --max-depth 3

Repository: doodlum/skyrim-community-shaders

Length of output: 58

🏁 Script executed:

#!/bin/bash
# Search for FEATURE_MINIMAL_VERSIONS definition
rg -l "FEATURE_MINIMAL_VERSIONS" .

Repository: doodlum/skyrim-community-shaders

Length of output: 138

🏁 Script executed:

#!/bin/bash
# Find .ini files with version information
fd -t f "\.ini$" . | head -20

Repository: doodlum/skyrim-community-shaders

Length of output: 1352

🏁 Script executed:

#!/bin/bash
# Check the actual PerformanceOverlay.ini file content
find . -name "PerformanceOverlay.ini" -type f -exec cat -n {} \;

Repository: doodlum/skyrim-community-shaders

Length of output: 112

🏁 Script executed:

#!/bin/bash
# Check the Feature.h file for version handling
cat -n ./src/Feature.h | head -100

Repository: doodlum/skyrim-community-shaders

Length of output: 3922

🏁 Script executed:

#!/bin/bash
# Look at cmake/FeatureVersions.h.in
cat -n ./cmake/FeatureVersions.h.in

Repository: doodlum/skyrim-community-shaders

Length of output: 357

🏁 Script executed:

#!/bin/bash
# Check InverseSquareLighting.ini for comparison
cat -n ./features/Inverse\ Square\ Lighting/Shaders/Features/InverseSquareLighting.ini

Repository: doodlum/skyrim-community-shaders

Length of output: 112

🏁 Script executed:

#!/bin/bash
# Search for where version numbers are validated or checked
rg -n "1-0-0|1-0-1|MINIMAL_VERSIONS" src/ cmake/ -A 2 -B 2 | head -100

Repository: doodlum/skyrim-community-shaders

Length of output: 1903

🏁 Script executed:

#!/bin/bash
# Find CMakeLists.txt files
fd -t f "CMakeLists.txt" . | head -10

Repository: doodlum/skyrim-community-shaders

Length of output: 157

🏁 Script executed:

#!/bin/bash
# Look at the main CMakeLists.txt to understand version generation
cat -n ./CMakeLists.txt | grep -A 10 -B 10 "FEATURE_VERSIONS\|FeatureVersions" | head -100

Repository: doodlum/skyrim-community-shaders

Length of output: 2011

🏁 Script executed:

#!/bin/bash
# Search for all .cmake files that might handle version generation
fd -t f "\.cmake$" cmake/

Repository: doodlum/skyrim-community-shaders

Length of output: 287

🏁 Script executed:

#!/bin/bash
# Check if there's a script that generates feature versions
find cmake/ -type f | xargs cat -n | grep -i "performanceoverlay\|feature.*version" -A 2 -B 2 | head -50

Repository: doodlum/skyrim-community-shaders

Length of output: 357

🏁 Script executed:

#!/bin/bash
# Look for the section in CMakeLists.txt that handles feature configs
cat -n ./CMakeLists.txt | grep -A 30 "FEATURE_CONFIG_FILES\|foreach.*FEATURE" | head -60

Repository: doodlum/skyrim-community-shaders

Length of output: 2161

🏁 Script executed:

#!/bin/bash
# Check if there are other files in the PerformanceOverlay feature that may have changed
find "./features/Performance Overlay" -type f | head -30

Repository: doodlum/skyrim-community-shaders

Length of output: 182

🏁 Script executed:

#!/bin/bash
# Look at git log to understand what files were changed in this PR
git log --oneline --all -20 2>/dev/null || echo "Git log not available"

Repository: doodlum/skyrim-community-shaders

Length of output: 1262

🏁 Script executed:

#!/bin/bash
# Check if there's a PR or commit message that explains the version bump
git show --stat HEAD 2>/dev/null | head -50 || echo "Git show not available"

Repository: doodlum/skyrim-community-shaders

Length of output: 3053

🏁 Script executed:

#!/bin/bash
# Check if there are other PerformanceOverlay source files that might have changed
find "./features/Performance Overlay" -o -path "./src/Features/PerformanceOverlay*" -type f | grep -v ".git"

Repository: doodlum/skyrim-community-shaders

Length of output: 162

🏁 Script executed:

#!/bin/bash
# Get detailed git diff for PerformanceOverlay files in this commit
git diff HEAD~1 HEAD --stat 2>/dev/null | grep -i "performanceoverlay\|inverse" || echo "Git diff not available"

Repository: doodlum/skyrim-community-shaders

Length of output: 98

🏁 Script executed:

#!/bin/bash
# Check what the commit message says about the changes
git log -1 --format=%B 2>/dev/null || echo "Git log message not available"

Repository: doodlum/skyrim-community-shaders

Length of output: 108

🏁 Script executed:

#!/bin/bash
# Look for any documentation in the PR or CHANGELOG that explains the version bump
find . -name "CHANGELOG*" -o -name "RELEASE*" -o -name "NOTES*" | xargs cat 2>/dev/null | head -50 || echo "No changelog found"

Repository: doodlum/skyrim-community-shaders

Length of output: 58

🏁 Script executed:

#!/bin/bash
# Correct find command to look for PerformanceOverlay files
find . -path "*/PerformanceOverlay*" -type f | grep -v ".git"

Repository: doodlum/skyrim-community-shaders

Length of output: 462

🏁 Script executed:

#!/bin/bash
# Check if other feature .ini files are at same version or different
rg "Version = " features/ --no-heading

Repository: doodlum/skyrim-community-shaders

Length of output: 2601

🏁 Script executed:

#!/bin/bash
# Search for any CI configuration that might require specific versions
fd -t f "\.yml\|\.yaml" .github/ | xargs grep -l "version\|Version" 2>/dev/null | head -5

Repository: doodlum/skyrim-community-shaders

Length of output: 58

🏁 Script executed:

#!/bin/bash
# Check if the PR/branch name gives us clues
git branch -a 2>/dev/null | head -20 || echo "Git branch not available"

Repository: doodlum/skyrim-community-shaders

Length of output: 170

Update PR description to explain the patch version bump.

The version increment is automatically picked up by the CMake build system which parses all feature .ini files and populates FEATURE_MINIMAL_VERSIONS accordingly, so no separate version map update is required. However, the current PR description "to make the CI happy" doesn't explain what changes to PerformanceOverlay necessitated this patch-level bump.

Per semantic versioning, clarify:

  • What backward-compatible bug fixes or improvements triggered this patch version
  • Reference any related issues using GitHub keywords (e.g., "Fixes #123" or "Addresses #123")
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@features/Performance` Overlay/Shaders/Features/PerformanceOverlay.ini at line
2, Update the PR description to explain why the PerformanceOverlay patch-level
version was bumped (referencing the Version = 1-0-1 entry in
Features/Performance Overlay/Shaders/Features/PerformanceOverlay.ini) by listing
the specific backward-compatible bug fixes or minor improvements included in
this change, citing any related GitHub issues or PRs with keywords like "Fixes
`#NNN`" or "Addresses `#NNN`", and note that no separate version map update is
required because the CMake build reads the .ini files to populate
FEATURE_MINIMAL_VERSIONS.

Loading