Skip to content

fix: preserve vanilla water TAA when no upscaler is active #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 2 commits into from
Mar 17, 2026
Merged

fix: preserve vanilla water TAA when no upscaler is active #1986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4c0234
fix: preserve vanilla water TAA when no upscaler is active
jturnley Mar 16, 2026
64214b0
Merge branch 'dev' into fix/upscaling-water-taa
jturnley Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/Features/Upscaling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,15 +1029,22 @@ void Upscaling::ConfigureTAA()
{
auto upscaleMethod = GetUpscaleMethod();

// When no upscaling method is active, leave vanilla TAA state untouched.
// The original UpdateJitter (called after this) manages water TAA and jitter
// correctly for the non-upscaling case. Overriding here disables ISWaterBlend,
// removing the 95% temporal history blend that stabilizes water reflections.
if (upscaleMethod == UpscaleMethod::kNONE)
return;

auto imageSpaceManager = RE::ImageSpaceManager::GetSingleton();
GET_INSTANCE_MEMBER(BSImagespaceShaderISTemporalAA, imageSpaceManager);

// Disable water TAA when upscaling is enabled
// CS TAA replaces vanilla TAA entirely, so disable water TAA (CS handles it).
// For FSR/DLSS, keep water TAA enabled since the upscaler needs the blend data.
bool* enableWaterTAA = reinterpret_cast<bool*>(reinterpret_cast<uintptr_t>(BSImagespaceShaderISTemporalAA) + 0x38LL);
*enableWaterTAA = !(upscaleMethod == UpscaleMethod::kNONE || upscaleMethod == UpscaleMethod::kTAA);
*enableWaterTAA = (upscaleMethod != UpscaleMethod::kTAA);

// Force enable TAA if needed
BSImagespaceShaderISTemporalAA->taaEnabled = upscaleMethod != UpscaleMethod::kNONE;
BSImagespaceShaderISTemporalAA->taaEnabled = true;
}

void Upscaling::ConfigureUpscaling(RE::BSGraphics::State* a_viewport)
Expand Down
Loading