-
Notifications
You must be signed in to change notification settings - Fork 138
fix(UI): improve theme management UI flow #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alandtse
merged 10 commits into
community-shaders:dev
from
brucenguyen:theme-management-ui-info-text
Feb 25, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
48a9ac8
refactor(UI): improve theme management UI flow
brucenguyen f1650a3
style: 🎨 apply pre-commit.ci formatting
pre-commit-ci[bot] 8d943ed
feat: theme preset codegen
brucenguyen 5612473
chore: out of bounds check
brucenguyen a489e60
fix: check sanitized theme name for empty error
brucenguyen a091a5b
chore: fix strlen misuse
brucenguyen 90e9ae2
chore: address AI nitpicks
brucenguyen 008a1d3
refactor: add new util helpers
brucenguyen 284767f
refactor: handle more edge cases for filename sanitation
brucenguyen b4f6ede
chore: remove unused imports
brucenguyen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #pragma once | ||
|
brucenguyen marked this conversation as resolved.
|
||
|
|
||
| #include <array> | ||
|
|
||
| namespace ThemePresets | ||
| { | ||
| inline constexpr std::array<const char*, @THEME_PRESET_COUNT@> names = { | ||
| @THEME_PRESET_NAMES@ | ||
| }; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.