Skip to content

chore: disable feature constraints in dev mode #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 2 commits into from
Feb 17, 2026
Merged

chore: disable feature constraints in dev mode #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e0eb4
chore: disable feature constraints in dev mode
alandtse Feb 17, 2026
d89a993
chore: remove manual constraints
alandtse Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/FeatureConstraints.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
#include "FeatureConstraints.h"
#include "Feature.h"
#include "Globals.h"
#include "State.h"

#include <unordered_set>

namespace FeatureConstraints
{
ConstraintResult GetConstraints(const SettingId& setting)
{
if (globals::state && globals::state->IsDeveloperMode())
return {};
ConstraintResult result;

for (auto* feature : Feature::GetFeatureList()) {
Expand Down Expand Up @@ -40,6 +44,8 @@ namespace FeatureConstraints

std::vector<std::pair<SettingId, ConstraintResult>> GetAllActiveConstraints()
{
if (globals::state && globals::state->IsDeveloperMode())
return {};
std::vector<std::pair<SettingId, ConstraintResult>> allConstraints;
std::unordered_set<std::string> processedKeys; // featureShortName|settingPath for O(1) lookup

Expand Down
19 changes: 0 additions & 19 deletions src/Features/Upscaling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include "Upscaling/FidelityFX.h"
#include "Upscaling/Streamline.h"
#include "Utils/UI.h"
#include "VR.h"
#include <Windows.h>
#include <algorithm>
#include <directx/d3dx12.h>
Expand Down Expand Up @@ -1087,24 +1086,6 @@ void Upscaling::ConfigureUpscaling(RE::BSGraphics::State* a_viewport)
// Disable dynamic resolution unless the game explicitly enables it
if (!globals::game::isVR)
runtimeData.dynamicResolutionLock = 1;

// If running in VR and an external upscaler is active, force-disable
// the engine's depth-buffer culling immediately. This ensures that
// enabling upscaling at runtime (after game load) does not leave the
// VR depth-buffer culling enabled which can cause incorrect occlusion.
if (globals::game::isVR) {
auto& vr = globals::features::vr;
if (IsUpscalingActive()) {
if (vr.gDepthBufferCulling) {
if (*vr.gDepthBufferCulling) {
*vr.gDepthBufferCulling = false;
logger::info("[Upscaling] VR detected - forcing depth buffer culling OFF due to active downscaling upscaler (scale={})", resolutionScale.x);
}
} else {
logger::warn("[Upscaling] VR depth buffer culling pointer is null, cannot force disable");
}
}
}
}

void Upscaling::SetupResources()
Expand Down