Skip to content

refactor: core feature version mismatch UI enhancement #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 1 commit into from
Feb 17, 2026
Merged

refactor: core feature version mismatch UI enhancement #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Feature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ void Feature::Load(json& o_json)

std::string minimalVersionString = Util::GetFormattedVersion(minimalFeatureVersion);

if (majorVersionMismatch) {
if (IsCore()) {
failedLoadedMessage = std::format("This feature is already included as part of the core Community Shaders installation. Uninstall this feature with your mod manager.");
} else if (majorVersionMismatch) {
failedLoadedMessage = std::format("{} {} is too old, major version incompatibility detected. Required: {}", GetShortName(), value, minimalVersionString);
} else {
failedLoadedMessage = std::format("{} {} is an old feature version, required: {}", GetShortName(), value, minimalVersionString);
Expand Down
21 changes: 18 additions & 3 deletions src/FeatureIssues.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace FeatureIssues
{
// Forward declarations
static void DrawFeatureIssue(const FeatureIssueInfo& issue, const ImVec4& color);
static bool IsVersionMismatchForCoreFeature(const FeatureIssueInfo& issue);

// Static storage for feature issues
static std::vector<FeatureIssueInfo> s_featureIssues;
Expand Down Expand Up @@ -401,7 +402,7 @@ namespace FeatureIssues
}
// Version Mismatch Section
if (auto section = Util::SectionWrapper("Wrong Version Features",
"The following features have version compatibility issues and were disabled automatically. Updating them may resolve the issues.",
"The following features have version compatibility issues and were disabled automatically. Please check for any updates or if the feature is considered obsolete.",
theme.StatusPalette.Warning, !versionIssues.empty())) {
for (const auto* issue : versionIssues) {
DrawFeatureIssue(*issue, theme.StatusPalette.Warning);
Expand Down Expand Up @@ -574,7 +575,13 @@ namespace FeatureIssues
}

// Handle download action for version mismatch features
if (issue.IsVersionMismatch()) {
if (IsVersionMismatchForCoreFeature(issue)) {
ImGui::SameLine();
ImGui::Text("Core feature already installed");
if (auto _tt = Util::HoverTooltipWrapper()) {
ImGui::TextWrapped("This feature is already included as part of the core Community Shaders installation. Uninstall this feature with your mod manager.");
}
} else if (issue.IsVersionMismatch()) {
ImGui::SameLine();

if (!issue.replacementFeatureModLink.empty()) {
Expand Down Expand Up @@ -625,7 +632,7 @@ namespace FeatureIssues
// Show delete button for:
// 1. Features that don't modify shader directories (safe to delete)
// 2. Obsolete features with replacements (user can install replacement after deletion)
bool canSafelyDelete = !issue.ModifiedShaderDirectory() || (issue.IsObsolete() && !issue.replacementFeature.empty());
bool canSafelyDelete = (!issue.ModifiedShaderDirectory() || (issue.IsObsolete() && !issue.replacementFeature.empty())) && !IsVersionMismatchForCoreFeature(issue);
if (canSafelyDelete) {
ImGui::SameLine();
std::string deleteButtonId = "Delete##" + issue.shortName;
Expand Down Expand Up @@ -699,6 +706,14 @@ namespace FeatureIssues
ImGui::PopID();
}

static bool IsVersionMismatchForCoreFeature(const FeatureIssueInfo& issue)
{
if (!issue.IsVersionMismatch())
return false;
Feature* f = s_featureLookupCache.FindFeature(issue.shortName);
return f && f->IsCore();
}

bool IsReplacementFeatureInstalled(const std::string& featureName)
{
Feature* feature = s_featureLookupCache.FindFeature(featureName);
Expand Down