Skip to content

fix(weather-editor): no-override weather file deletion (#1777) #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 3 commits into from
Jan 30, 2026
Merged

fix(weather-editor): no-override weather file deletion (#1777) #1777

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f9f947
prevent deletion when no featuresettings are left.
Jan 28, 2026
bc40bb0
Merge branch 'doodlum:dev' into prevent-file-deletion
SkrubbySkrubInAShrub Jan 28, 2026
b59a89e
apply AI comment
Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/WeatherManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,18 @@ void WeatherManager::SaveSettingsToWeather(RE::TESWeather* weather, const std::s
}

// Write back to disk
if (featureSettings.empty()) {
// No features left for this weather — remove file if it exists
// Only delete file if featureSettings is empty AND weatherData contains only featureSettings (no other data)
if (featureSettings.empty() && weatherData.size() == 1 && weatherData.contains("featureSettings")) {
std::error_code ec;
if (std::filesystem::remove(filePath, ec)) {
logger::info("Removed weather settings file (no features remain): {}", filePath);
} else if (ec) {
logger::warn("Failed to remove empty weather settings file ({}): {}", filePath, ec.message());
logger::info("Removed weather settings file (no data remain): {}", filePath);
return;
}
return;
if (ec == std::errc::no_such_file_or_directory) {
return;
}
logger::warn("Failed to remove empty weather settings file ({}): {}", filePath, ec.message());
// fall through to write updated JSON as a best-effort fallback
}

std::ofstream settingsFile(filePath);
Expand Down