fix(weather): detection of overrides

[SkrubbySkrubInAShrub]

The __enabled flag was being filtered out when loading cached weather settings,
preventing the UI from detecting that overrides were enabled.
The presence of this __enabled flag is not harmful as it gets filtered later when used by the lerping function.
When the overrides are enabled in the UI, this flag is also added to this cache, so this flag is almost always present except when loading the settings at startup.

Summary by CodeRabbit

• Bug Fixes
  • Improved weather settings data handling to ensure all configuration values are properly retained.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified LoadSettingsFromWeather to directly assign the entire featureJson object to o_json when a weather-specific feature is enabled, rather than filtering out the __enabled key. Reduces code by six lines while maintaining existing control flow and error handling.

Changes

Cohort / File(s)	Summary
Weather Settings Assignment Logic src/WeatherManager.cpp	Changed LoadSettingsFromWeather to include __enabled key in o_json by assigning full featureJson object instead of filtering keys; net reduction of 6 lines

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat(weather): per-feature settings rework, main feature lock #1704: Modifies the same LoadSettingsFromWeather function but takes a conflicting approach—filters out __enabled and copies remaining keys, whereas this PR includes __enabled in the assignment.

Suggested reviewers

• doodlum
• davo0411
• jiayev

Poem

🐰 A rabbit hops through JSON trees,
Simplifying with such ease—
No filtering, just one assign,
The whole featureJson shines so fine! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'fix(weather): detection of overrides' is vague and generic. It does not clearly describe the specific change (removing __enabled flag filtering) or its purpose (preventing UI from detecting overrides). While it relates to the PR's domain, it lacks specificity about what fix was applied.	Consider a more specific title like 'fix(weather): preserve __enabled flag in LoadSettingsFromWeather' or 'fix(weather): don't strip __enabled flag to enable override detection' that better describes the actual code change.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: a22883c
Using base ref: a22883c
Base commit date: 2026-01-25T13:13:46-08:00 (Sunday, January 25, 2026 01:13 PM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download