Skip to content

build: update CommonLib v4.0.0 #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 14 commits into from
Jan 24, 2026
Merged

build: update CommonLib v4.0.0 #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cc5f1c7
Initial plan
Copilot Jan 19, 2026
5b6df7f
chore: update CommonLibSSE-NG to ng branch (9228685c) - Windows testi…
Copilot Jan 19, 2026
dda12bb
Fix CommonLibSSE-NG ng branch API changes
Copilot Jan 20, 2026
93d7502
fix: restore GET_INSTANCE_MEMBER for VR compatibility with maskIndex
Copilot Jan 20, 2026
280ad83
fix: remove build document and fix NiPointer explicit constructor iss…
Copilot Jan 20, 2026
598094e
fix: use implicit NiPointer conversion for portalGraph->rooms
Copilot Jan 20, 2026
b3dc5b9
fix: restore GET_INSTANCE_MEMBER for all VR compatibility points and …
Copilot Jan 20, 2026
9588083
fix: update to latest ng and remove unnecessary casts
Copilot Jan 20, 2026
c964cd6
chore: update CommonLib to latest ng (51876f05c)
Copilot Jan 22, 2026
43cb02f
fix: propagate ENABLE_SKYRIM_* defines for STATIC_ASSERT_SIZE macro
Copilot Jan 22, 2026
389f1e8
fix: normalize ENABLE_SKYRIM_* to boolean before CommonLib init
Copilot Jan 22, 2026
77776aa
fix: update CommonLib-NG with conforming preprocessor fix
alandtse Jan 22, 2026
d7717a8
revert: remove unnecessary ENABLE_SKYRIM_* workarounds
alandtse Jan 22, 2026
3753a45
fix: fix VR volumetric lighting
alandtse Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extern/CommonLibSSE-NG
Open in desktop
Submodule CommonLibSSE-NG updated 1686 files
8 changes: 1 addition & 7 deletions src/Features/InteriorSun.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,6 @@ void InteriorSun::ClearArrays()
arraysCleared = true;
}

namespace RE
{
class BSMultiBoundRoom : public NiNode
{};
}

void InteriorSun::PopulateReplacementJobArrays(RE::TESObjectCELL* cell, const RE::NiPointer<RE::BSPortalGraph>& portalGraph, const RE::BSShadowDirectionalLight* dirLight, RE::BSTArray<RE::BSTArray<RE::NiPointer<RE::NiAVObject>>>& jobArrays)
{
if (cell != currentCell) {
Expand Down Expand Up @@ -185,7 +179,7 @@ void InteriorSun::PopulateReplacementJobArrays(RE::TESObjectCELL* cell, const RE
}

const auto playerPos = RE::PlayerCharacter::GetSingleton()->GetPosition();
auto lightDir = -dirLight->GetShadowDirectionalLightRuntimeData().lightDirection;
auto lightDir = -dirLight->GetShadowDirectionalLightRuntimeData().sunVector;
lightDir.Unitize();

// Add extra rooms and portals that are in the direction of the sun
Expand Down
18 changes: 6 additions & 12 deletions src/Features/LightLimitFix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ void LightLimitFix::BSLightingShader_SetupGeometry_GeometrySetupConstantPointLig

if (i < a_pass->numShadowLights) {
auto* shadowLight = static_cast<RE::BSShadowLight*>(bsLight);
GET_INSTANCE_MEMBER(shadowLightIndex, shadowLight);
light.shadowMaskIndex = shadowLightIndex;
GET_INSTANCE_MEMBER(maskIndex, shadowLight);
light.shadowMaskIndex = maskIndex;
light.lightFlags.set(LightFlags::Shadow);
}

Expand All @@ -266,8 +266,8 @@ void LightLimitFix::BSLightingShader_SetupGeometry_GeometrySetupConstantPointLig
for (uint32_t i = 0; i < a_pass->numShadowLights; i++) {
auto bsLight = a_pass->sceneLights[i + 1];
auto* shadowLight = static_cast<RE::BSShadowLight*>(bsLight);
GET_INSTANCE_MEMBER(shadowLightIndex, shadowLight);
strictLightDataTemp.ShadowBitMask |= (1 << shadowLightIndex);
GET_INSTANCE_MEMBER(maskIndex, shadowLight);
strictLightDataTemp.ShadowBitMask |= (1 << maskIndex);
}
}

Expand Down Expand Up @@ -375,12 +375,6 @@ void LightLimitFix::ClearShaderCache()
clusterCullingCS = (ID3D11ComputeShader*)Util::CompileShader(L"Data\\Shaders\\LightLimitFix\\ClusterCullingCS.hlsl", {}, "cs_5_0");
}

namespace RE
{
class BSMultiBoundRoom : public NiNode
{};
}

void LightLimitFix::UpdateLights()
{
auto smState = globals::game::smState;
Expand Down Expand Up @@ -447,8 +441,8 @@ void LightLimitFix::UpdateLights()

if (bsLight->IsShadowLight()) {
auto* shadowLight = static_cast<RE::BSShadowLight*>(bsLight);
GET_INSTANCE_MEMBER(shadowLightIndex, shadowLight);
light.shadowMaskIndex = shadowLightIndex;
GET_INSTANCE_MEMBER(maskIndex, shadowLight);
light.shadowMaskIndex = maskIndex;
light.lightFlags.set(LightFlags::Shadow);
}

Expand Down
2 changes: 1 addition & 1 deletion src/Menu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ void Menu::OnFocusChanged()
// Solves the alt+tab stuck issue, but disables tab after tabbing back in.
if (const auto& inputMgr = RE::BSInputDeviceManager::GetSingleton()) {
if (const auto& device = inputMgr->GetKeyboard()) {
device->Reset();
device->ClearInputState();
}
}
// Allows tab to work again after alt+tabbing back in.
Expand Down
Loading