Skip to content

fix(upscaling): disable water TAA instead of enable#1726

Merged
doodlum merged 1 commit into
community-shaders:devfrom
jiayev:disablewaterblend
Jan 17, 2026
Merged

fix(upscaling): disable water TAA instead of enable#1726
doodlum merged 1 commit into
community-shaders:devfrom
jiayev:disablewaterblend

Conversation

@jiayev
Copy link
Copy Markdown
Collaborator

@jiayev jiayev commented Jan 17, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed water temporal anti-aliasing to properly activate based on the selected upscaling method. Water TAA is now enabled when using DLSS or FSR upscaling, improving visual consistency in water rendering.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

The Upscaling::ConfigureTAA method's water TAA enabling condition has been inverted. Water TAA is now enabled when using DLSS or FSR upscaling methods, rather than when using no upscaling or TAA only.

Changes

Cohort / File(s) Summary
Water TAA Configuration Logic
src/Features/Upscaling.cpp
Inverted conditional logic determining when water TAA is enabled based on upscaleMethod selection

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • doodlum

Poem

🐰✨ A hop, a skip, a flip of condition!
Water TAA dances with DLSS ambition,
When FSR flows and upscaling gleams,
The shader-shimmers fulfill their dreams! 💧

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ⚠️ Warning The title states 'disable water TAA instead of enable' but the actual change inverts the logic—enabling water TAA when upscaling (DLSS/FSR) is active, not disabling it. Update the title to accurately reflect the change: 'fix(upscaling): invert water TAA condition for upscaling methods' or similar to clarify the logic inversion.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Using provided base ref: 43b7727
Using base ref: 43b7727
Base commit date: 2026-01-17T01:57:42Z (Saturday, January 17, 2026 01:57 AM)
No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

Comment thread src/Features/Upscaling.cpp
@alandtse
Copy link
Copy Markdown
Collaborator

I'm approving but I don't think the title matches what this is doing. You're changing TAA no? @jiayev

@doodlum doodlum changed the title fix(upscaling): disable water blend fix(upscaling): disable water TAA instead of enable Jan 17, 2026
@doodlum doodlum merged commit fde3f5a into community-shaders:dev Jan 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants