Skip to content

fix(weather editor): reorder categories for better intuition.#1725

Merged
doodlum merged 3 commits into
community-shaders:devfrom
SkrubbySkrubInAShrub:reorder-weather-editor-categories
Jan 17, 2026
Merged

fix(weather editor): reorder categories for better intuition.#1725
doodlum merged 3 commits into
community-shaders:devfrom
SkrubbySkrubInAShrub:reorder-weather-editor-categories

Conversation

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented Jan 16, 2026

This pull request updates the default category selection and reorganizes the category list in the objects window of the weather editor. The changes improve the user experience by prioritizing "Weather" as the default and making the category list more intuitive.

UI/UX improvements:

  • Changed the default selected category from "Lighting Template" to "Weather" in the ShowObjectsWindow method (EditorWindow.cpp).
  • Reordered the categories array so that "Weather" appears first, and the order is more logical for users browsing weather-related objects (EditorWindow.cpp).

Summary by CodeRabbit

  • Chores
    • Changed the default selected category and reordered the category options displayed in the editor window.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 16, 2026

📝 Walkthrough

Walkthrough

The changes modify the WeatherEditor's ShowObjectsWindow to reorder the categories array, moving "Weather" to the first position and updating the default selected category from "Lighting Template" to "Weather".

Changes

Cohort / File(s) Summary
Category Reordering
src/WeatherEditor/EditorWindow.cpp
Reordered categories array with "Weather" moved to first position; updated default selected category from "Lighting Template" to "Weather"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • jiayev

Poem

🐰 A weather rabbit hops with glee,
The categories dance in harmony!
"Weather" now leads the grand parade,
First in the list, a new crusade! 🌦️

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reordering categories in the weather editor for improved intuitiveness. It directly matches the PR's primary objectives of reorganizing the category order and changing the default selection.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Using provided base ref: e389a33
Using base ref: e389a33
Base commit date: 2026-01-16T22:36:01Z (Friday, January 16, 2026 10:36 PM)
No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@doodlum doodlum merged commit bc7c8d9 into community-shaders:dev Jan 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants