Skip to content

chore(linear lighting): new Linear defaults#1697

Merged
doodlum merged 1 commit into
community-shaders:devfrom
Dlizzio:fix(LL)-new-Linear-defaults
Jan 12, 2026
Merged

chore(linear lighting): new Linear defaults#1697
doodlum merged 1 commit into
community-shaders:devfrom
Dlizzio:fix(LL)-new-Linear-defaults

Conversation

@Dlizzio
Copy link
Copy Markdown
Contributor

@Dlizzio Dlizzio commented Jan 12, 2026

Set new Linear Lighting defaults with the intent of matching the diffuse brightness with PBR textures, fog to average implementation of sky vs fog color, effect to match when linear is disabled, and compensating for bright glow maps. All tested.

Summary by CodeRabbit

  • Style
    • Fine-tuned default rendering parameters to enhance visual appearance. Adjusted gamma correction values for colors, emissions, fog effects, glow mapping, and visual elements. These optimizations improve overall visual quality, consistency, and rendering fidelity across the application.

✏️ Tip: You can customize this high-level summary in your review settings.

Set new Linear Lighting defaults with the intent of matching the diffuse brightness with non PBR textures, fog to average implementation of sky vs fog color, effect to when linear is disabled, and compensating for bright glow maps. All tested.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

Updated gamma-related configuration defaults in LinearLighting Settings struct, including adjustments to colorGamma, emitColorGamma, glowmapGamma, fogGamma, fogAlphaGamma, effectGamma, effectAlphaGamma, and glowmapMult values.

Changes

Cohort / File(s) Summary
LinearLighting Configuration Defaults
src/Features/LinearLighting.h
Updated 8 gamma and multiplier default values: colorGamma (2.2f → 1.8f), emitColorGamma (2.2f → 1.8f), glowmapGamma (2.2f → 1.8f), fogGamma (2.2f → 1.97f), fogAlphaGamma (1.0f → 1.8f), effectGamma (1.8f → 1.4f), effectAlphaGamma (1.0f → 1.55f), glowmapMult (1.0f → 0.5f).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • jiayev
  • doodlum
  • davo0411

Poem

🐰 The gamma values dance and shift so fine,
Lighting calibrated in each glowing line,
From fog to color, the defaults are now bright,
A rabbit's touch ensures the rendering's just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating Linear Lighting default configuration values.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Using provided base ref: 94f854f
Using base ref: 94f854f
Base commit date: 2026-01-12T11:16:56+10:00 (Monday, January 12, 2026 11:16 AM)
No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@doodlum doodlum changed the title fix(LL): new Linear defaults chore(linear lighting): new Linear defaults Jan 12, 2026
@doodlum doodlum merged commit ea9121f into community-shaders:dev Jan 12, 2026
20 checks passed
@Dlizzio Dlizzio deleted the fix(LL)-new-Linear-defaults branch March 27, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants