fix(grass collision): ignore hkpListShape

[doodlum]

Ignore hkpListShape like found in https://www.nexusmods.com/skyrimspecialedition/mods/69701 to fix bad collisions.

It would be better for someone to add support for parsing this type of list, this is a quick fix.

Untested.

Summary by CodeRabbit

• Bug Fixes
  • Improved stability by preventing processing of unsupported shape configurations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

An additional validation guard is added to GetShapeBound in the actor utility module to skip processing when the hkpRigid shape is an unsupported hkpListShape, while preserving the existing flow for valid shape types.

Changes

Cohort / File(s)	Summary
Shape validation guard src/Utils/ActorUtils.cpp	Added guard to skip hkpListShape types in GetShapeBound; existing mass center and shape bound extraction logic remains unchanged for supported shapes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• alandtse
• doodlum

Poem

🐰 A guard stands tall, both straight and true,
To filter shapes both old and new,
When lists would slip through without care,
We catch them now, we're always there!
One little check keeps logic sound,
Safe shapes alone on solid ground. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a guard to ignore hkpListShape in collision handling, which directly addresses the grass collision issue mentioned in the PR objectives.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: 1bb4d08
Using base ref: 1bb4d08
Base commit date: 2025-12-30T12:39:34-08:00 (Tuesday, December 30, 2025 12:39 PM)
No actionable suggestions for changed features.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bb4d08 and 72f96b0.

📒 Files selected for processing (1)

• src/Utils/ActorUtils.cpp

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

• src/Utils/ActorUtils.cpp

src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

• src/Utils/ActorUtils.cpp

**/*

⚙️ CodeRabbit configuration file

**/*: When reviewing PRs, please provide suggestions for:

1. Conventional Commit Titles (if not following https://www.conventionalcommits.org/ or
   if the existing title does not describe the code changes):
   Format: type(scope): description
   Length: 50 characters limit for title, 72 for body
   Style: lowercase description, no ending period
   Examples:

   • feat(vr): add cross-eye sampling
   • fix(water): resolve flowmap bug
   • docs: update shader documentation

2. Issue References (if PR fixes bugs or implements features):
   Suggest adding appropriate GitHub keywords:

   • "Fixes #123" or "Closes #123" for bug fixes
   • "Implements #123" or "Addresses #123" for features
   • "Related to #123" for partial implementations

Otherwise, use your standard review approach focusing on code quality.

Files:

• src/Utils/ActorUtils.cpp

🧠 Learnings (1)

📓 Common learnings

Learnt from: alandtse
Repo: doodlum/skyrim-community-shaders PR: 0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build plugin and addons

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Test the change and consider adding logging.

The logic correctly skips hkpListShape by checking that the cast returns nullptr. However:

1. Testing required: The PR is marked as untested. Collision handling changes need verification to ensure objects with hkpListShape don't lose collision entirely or cause other regressions.

2. Observability gap: Consider logging when shapes are skipped to aid debugging. Users or developers troubleshooting collision issues won't know if hkpListShape was encountered and ignored.

📋 Suggested improvement: Add logging

-	if (bhkRigid && hkpRigid && !skyrim_cast<RE::hkpListShape*>(hkpRigid)) {  // Ignore hkpListShape, unsupported
+	auto* listShape = skyrim_cast<RE::hkpListShape*>(hkpRigid);
+	if (listShape) {
+		// hkpListShape is unsupported; proper parsing of child shapes not implemented
+		logger::debug("Skipping unsupported hkpListShape in collision bounds calculation");
+		return false;
+	}
+	if (bhkRigid && hkpRigid) {

Please verify this change doesn't cause collisions to fail for actors or objects that commonly use hkpListShape:

#!/bin/bash
# Search for any existing hkpListShape handling or references in the codebase
rg -n -C3 'hkpListShape' --type=cpp

#!/bin/bash
# Check if there are tests for GetShapeBound or collision handling
fd -e cpp -e h test | xargs rg -l 'GetShapeBound|ActorUtils' 

[github-actions]

✅ A pre-release build is available for this PR:
Download

[davo0411]

can't reasonably merge until tested