Skip to content

refactor(water-effects): move to core #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davo0411 wants to merge 6 commits into from
Closed

refactor(water-effects): move to core #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ad35fd
fixes
davo0411 Dec 21, 2025
de68b40
remove broken description
davo0411 Dec 30, 2025
b6e3364
Update src/Features/WaterEffects.cpp
davo0411 Dec 31, 2025
be4dfe9
style: 🎨 apply pre-commit.ci formatting
pre-commit-ci[bot] Dec 31, 2025
7e07e13
Merge branch 'doodlum:dev' into water-effects-semantics
davo0411 Jan 4, 2026
d954816
fix: file corruption
davo0411 Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added features/Water Effects/CORE
View file
Open in desktop
Empty file.
2 changes: 1 addition & 1 deletion src/Features/WaterEffects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ void WaterEffects::Prepass()
bool WaterEffects::HasShaderDefine(RE::BSShader::Type)
{
return true;
}
}
7 changes: 4 additions & 3 deletions src/Features/WaterEffects.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ struct WaterEffects : Feature
virtual std::pair<std::string, std::vector<std::string>> GetFeatureSummary() override
{
return {
"Water Effects enhances water rendering with realistic caustics and underwater lighting effects.\n"
"This feature adds dynamic light patterns and improved water visual quality.",
"This feature implements basic water effects, including parallax, flow map parallax, caustics and lighting tweaks.",
{ "Realistic water caustics",
"Enhanced underwater lighting",
"Dynamic light patterns on water surfaces",
Expand All @@ -28,11 +27,13 @@ struct WaterEffects : Feature
};
}

virtual bool IsCore() const override { return true; }

bool HasShaderDefine(RE::BSShader::Type shaderType) override;

virtual void SetupResources() override;

virtual void Prepass() override;

virtual bool SupportsVR() override { return true; };
virtual bool SupportsVR() override { return true; }
};