Skip to content

fix(perf-overlay): fix infinite draw calls table height #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 1 commit into from
Nov 4, 2025
Merged

fix(perf-overlay): fix infinite draw calls table height #1590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/Utils/UI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ namespace Util
* Each function should compare two rows and return true if the first should come before the second.
* @param cellRender Function to render a cell: (rowIdx, colIdx, const T& row).
* @param footerRows Optional static footer rows (not sorted, rendered after main rows).
* @param outerSize Optional outer size for the table (0,0 = auto-size).
*/
template <typename T>
void ShowSortedStringTableCustom(
Expand All @@ -385,10 +386,16 @@ namespace Util
bool ascending,
const std::vector<std::function<bool(const T&, const T&, bool)>>& customSorts,
std::function<void(int, int, const T&)> cellRender,
const std::vector<T>& footerRows = {})
const std::vector<T>& footerRows = {},
const ImVec2& outerSize = ImVec2(0, 0))
{
ImGuiTableFlags flags = ImGuiTableFlags_Borders | ImGuiTableFlags_RowBg | ImGuiTableFlags_Sortable | ImGuiTableFlags_Resizable | ImGuiTableFlags_ScrollX | ImGuiTableFlags_ScrollY | ImGuiTableFlags_SizingStretchProp;
if (ImGui::BeginTable(table_id, static_cast<int>(headers.size()), flags)) {
ImVec2 tableSize = outerSize;
if (outerSize.y == 0.0f) {
size_t totalRows = rows.size() + footerRows.size();
tableSize.y = ImGui::GetTextLineHeightWithSpacing() * (static_cast<float>((totalRows < 15) ? totalRows : 15) + 1.2f);
}
if (ImGui::BeginTable(table_id, static_cast<int>(headers.size()), flags, tableSize)) {
// Set up columns with content-based sizing
for (size_t i = 0; i < headers.size(); ++i) {
ImGui::TableSetupColumn(headers[i].c_str());
Expand Down