chore(upscaling): update streamline sdk#1450
Conversation
WalkthroughRemoved gating logic that conditionally disabled reactive/transparency masks in Streamline::Upscale and advanced the extern/Streamline-DX12 submodule pointer; masks are now always constructed from the provided pointers. No public/exported signatures changed. Changes
Sequence Diagram(s)Old flow (conditional mask construction) sequenceDiagram
participant Caller
participant Upscale as Streamline::Upscale
participant StreamlineAPI
Note over Upscale: Old behavior
Caller->>Upscale: call Upscale(a_reactiveMask, a_transparencyCompositionMask, preset)
Upscale->>Upscale: compute needsMask from preset
alt needsMask == true
Upscale->>StreamlineAPI: reactiveMask(created from a_reactiveMask)
Upscale->>StreamlineAPI: transparencyMask(created from a_transparencyCompositionMask)
else needsMask == false
Upscale->>StreamlineAPI: reactiveMask(nullptr)
Upscale->>StreamlineAPI: transparencyMask(nullptr)
end
StreamlineAPI-->>Caller: result
New flow (always construct masks) sequenceDiagram
participant Caller
participant Upscale as Streamline::Upscale
participant StreamlineAPI
Note over Upscale: New behavior (always construct)
Caller->>Upscale: call Upscale(a_reactiveMask, a_transparencyCompositionMask, preset)
Upscale->>StreamlineAPI: reactiveMask(created from a_reactiveMask)
Upscale->>StreamlineAPI: transparencyMask(created from a_transparencyCompositionMask)
StreamlineAPI-->>Caller: result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{cpp,cxx,cc,h,hpp,hxx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ A pre-release build is available for this PR: |
Summary by CodeRabbit
Chores
Bug Fixes