Skip to content

chore(upscaling): update streamline sdk#1450

Merged
doodlum merged 2 commits into
devfrom
update-streamline-sdkl
Sep 8, 2025
Merged

chore(upscaling): update streamline sdk#1450
doodlum merged 2 commits into
devfrom
update-streamline-sdkl

Conversation

@doodlum
Copy link
Copy Markdown
Collaborator

@doodlum doodlum commented Sep 8, 2025

Summary by CodeRabbit

  • Chores

    • Updated the Streamline-DX12 external dependency to a newer revision (reference update only).
  • Bug Fixes

    • Upscaling now always passes provided reactive and transparency masks instead of conditionally skipping them for certain presets, ensuring masks supplied by callers are consistently applied.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 8, 2025

Walkthrough

Removed gating logic that conditionally disabled reactive/transparency masks in Streamline::Upscale and advanced the extern/Streamline-DX12 submodule pointer; masks are now always constructed from the provided pointers. No public/exported signatures changed.

Changes

Cohort / File(s) Summary of changes
Submodule pointer
extern/Streamline-DX12
Updated submodule commit pointer from 7mdCoRPc1omTiZdYY2xG81EvGwN7Z2yodUTX9ZmLm3fx to b998246a3d499c08765c5681b229c9e6b4513348; no parent-repo code modifications.
Upscale mask logic
src/Features/Upscaling/Streamline.cpp
Removed needsMask gating and now always constructs reactiveMask and transparencyCompositionMask directly from the provided pointers (no longer conditional on preset). No signature changes.

Sequence Diagram(s)

Old flow (conditional mask construction)

sequenceDiagram
    participant Caller
    participant Upscale as Streamline::Upscale
    participant StreamlineAPI
    Note over Upscale: Old behavior
    Caller->>Upscale: call Upscale(a_reactiveMask, a_transparencyCompositionMask, preset)
    Upscale->>Upscale: compute needsMask from preset
    alt needsMask == true
        Upscale->>StreamlineAPI: reactiveMask(created from a_reactiveMask)
        Upscale->>StreamlineAPI: transparencyMask(created from a_transparencyCompositionMask)
    else needsMask == false
        Upscale->>StreamlineAPI: reactiveMask(nullptr)
        Upscale->>StreamlineAPI: transparencyMask(nullptr)
    end
    StreamlineAPI-->>Caller: result
Loading

New flow (always construct masks)

sequenceDiagram
    participant Caller
    participant Upscale as Streamline::Upscale
    participant StreamlineAPI
    Note over Upscale: New behavior (always construct)
    Caller->>Upscale: call Upscale(a_reactiveMask, a_transparencyCompositionMask, preset)
    Upscale->>StreamlineAPI: reactiveMask(created from a_reactiveMask)
    Upscale->>StreamlineAPI: transparencyMask(created from a_transparencyCompositionMask)
    StreamlineAPI-->>Caller: result
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • jiayev
  • alandtse

Poem

I nibble code and twitch my nose,
A pointer hops where fresh wind blows.
Masks once hidden, now step into light—
A quiet change, but tidy and right.
Thump-thump, I stamp the patch with delight.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  - Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
  - Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6422b10 and 9dee195.

📒 Files selected for processing (1)
  • src/Features/Upscaling/Streamline.cpp (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

  • src/Features/Upscaling/Streamline.cpp
src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

  • src/Features/Upscaling/Streamline.cpp
🧠 Learnings (1)
📓 Common learnings
Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build plugin and addons
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-streamline-sdkl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2025

Using provided base ref: 62f2202
Using base ref: 62f2202
Base commit date: 2025-09-08T18:59:44+01:00 (Monday, September 08, 2025 06:59 PM)
No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2025

✅ A pre-release build is available for this PR:
Download

@doodlum doodlum merged commit 5f6325f into dev Sep 8, 2025
17 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Sep 16, 2025
@alandtse alandtse deleted the update-streamline-sdkl branch February 6, 2026 05:20
@coderabbitai coderabbitai Bot mentioned this pull request Apr 23, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants