chore: remove hdr shader hacks#1444
Conversation
WalkthroughThis PR removes HDR/adaptation handling from the deferred renderer: deletion of adaptation texture setup, LUT loading, and HDR shader hack/binding functions in Deferred, plus removal of the HDRShaderHacks() call in State::Draw. Public API members for these features are removed from Deferred. No other control flow is changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Game
participant State as State::Draw
participant Deferred as Deferred
Note over Game,Deferred: Previous flow (with HDR hack)
Game->>State: Draw()
State->>Deferred: HDRShaderHacks() <<removed>>
State->>Deferred: Other draw bindings
rect rgba(230,245,255,0.5)
Note over Game,Deferred: New flow (simplified)
Game->>State: Draw()
State->>Deferred: Other draw bindings
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ A pre-release build is available for this PR: |
Removes LUT texture and adaptation texture changes because being replaced with PP anyway and not sure how well that stuff works anyway
Summary by CodeRabbit