chore(SSGI): set quarter res as default and revise presets#1442
Conversation
WalkthroughChanged ScreenSpaceGI default resolution from half to quarter by updating Changes
Sequence Diagram(s)(omitted — changes are UI/default value edits, not control-flow modifications) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
✅ A pre-release build is available for this PR: |
Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Features/ScreenSpaceGI.cpp (1)
829-831: Typo in comment: “upsasmple” → “upsample”Minor readability nit.
- // upsasmple + // upsample
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/Features/ScreenSpaceGI.cpp(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Do not include TODO/FIXME placeholders; provide complete, working solutions
Files:
src/Features/ScreenSpaceGI.cpp
src/**/*.{cpp,cxx,cc,h,hpp,hxx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code
Files:
src/Features/ScreenSpaceGI.cpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build plugin and addons
🔇 Additional comments (2)
src/Features/ScreenSpaceGI.cpp (2)
121-131: Approve “High” mapping and tooltips
ResolutionMode = 1 correctly implements half-res “High” and leaves “Reference” at full-res. No stale “Extreme” or “Full res and clean.” references remain.
109-119: Unable to locateScreenSpaceGI.h: please manually verify that the header’s defaultResolutionModeis set to2to ensure the “Standard” preset stays at quarter resolution.
Normal preset + quarter res is what the "A Dragonborn's Fate" guide uses as default. This is a sensible default thanks to the way lower GPU cost and stable enough presentation.
The normal preset was updated to match this and Extreme is now named High, which is the only preset option using half res. Only Reference uses full res.
Summary by CodeRabbit
New Features
Chores