Skip to content

chore(SSGI): set quarter res as default and revise presets#1442

Merged
doodlum merged 5 commits into
community-shaders:devfrom
Ungeziefi:single-commit-pr
Sep 6, 2025
Merged

chore(SSGI): set quarter res as default and revise presets#1442
doodlum merged 5 commits into
community-shaders:devfrom
Ungeziefi:single-commit-pr

Conversation

@Ungeziefi
Copy link
Copy Markdown
Contributor

@Ungeziefi Ungeziefi commented Sep 4, 2025

Normal preset + quarter res is what the "A Dragonborn's Fate" guide uses as default. This is a sensible default thanks to the way lower GPU cost and stable enough presentation.

The normal preset was updated to match this and Extreme is now named High, which is the only preset option using half res. Only Reference uses full res.

Summary by CodeRabbit

  • New Features

    • None.
  • Chores

    • Default Screen Space Global Illumination now uses quarter-scale to improve performance and reduce GPU usage; users can still choose quarter/half/full in graphics settings.
    • UI preset updates: "Extreme" renamed to "High"; "Standard" now uses quarter res and "High" uses half res; preset descriptions/tooltips updated.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 4, 2025

Walkthrough

Changed ScreenSpaceGI default resolution from half to quarter by updating Settings::ResolutionMode default in the header and adjusted UI presets and tooltips in the implementation to match the new defaults and relabel one preset.

Changes

Cohort / File(s) Summary of Changes
Settings default
src/Features/ScreenSpaceGI.h
Changed ScreenSpaceGI::Settings::ResolutionMode default initializer from 1 (half) to 2 (quarter) and updated the inline comment to indicate DBF default.
UI preset mappings
src/Features/ScreenSpaceGI.cpp
Updated DrawSettings presets: Standard now sets ResolutionMode = 2 (quarter) with tooltip "Quarter res and somewhat stable."; Extreme preset renamed to High with label "High", now sets ResolutionMode = 1 (half) and tooltip "Half res and clean."; corrected "upsasmple" → "upsample" comment; other presets unchanged.

Sequence Diagram(s)

(omitted — changes are UI/default value edits, not control-flow modifications)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • alandtse

Poem

A rabbit tweaks the shadowed hue,
quarter pixels in a queue.
Labels hopped and tooltips told,
presets nudged from bold to mild—
snip-snip, code trimmed neat and new.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 716029f and 56d5e8a.

📒 Files selected for processing (1)
  • src/Features/ScreenSpaceGI.cpp (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Features/ScreenSpaceGI.cpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build plugin and addons
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

Using provided base ref: d7c65f9
Using base ref: d7c65f9
Base commit date: 2025-09-03T23:25:04+01:00 (Wednesday, September 03, 2025 11:25 PM)
No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

✅ A pre-release build is available for this PR:
Download

Ungeziefi and others added 2 commits September 4, 2025 03:31
Automated formatting by clang-format, prettier, and other hooks.
See https://pre-commit.ci for details.
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/Features/ScreenSpaceGI.cpp (1)

829-831: Typo in comment: “upsasmple” → “upsample”

Minor readability nit.

-  // upsasmple
+  // upsample
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a78fba1 and 716029f.

📒 Files selected for processing (1)
  • src/Features/ScreenSpaceGI.cpp (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

  • src/Features/ScreenSpaceGI.cpp
src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

  • src/Features/ScreenSpaceGI.cpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build plugin and addons
🔇 Additional comments (2)
src/Features/ScreenSpaceGI.cpp (2)

121-131: Approve “High” mapping and tooltips
ResolutionMode = 1 correctly implements half-res “High” and leaves “Reference” at full-res. No stale “Extreme” or “Full res and clean.” references remain.


109-119: Unable to locate ScreenSpaceGI.h: please manually verify that the header’s default ResolutionMode is set to 2 to ensure the “Standard” preset stays at quarter resolution.

@Ungeziefi Ungeziefi changed the title SSGI quarter res default SSGI quarter res default and revised presets Sep 4, 2025
@doodlum doodlum changed the title SSGI quarter res default and revised presets chore(SSGI) : set quarter res as default and revise presets Sep 6, 2025
@doodlum doodlum changed the title chore(SSGI) : set quarter res as default and revise presets chore(SSGI): set quarter res as default and revise presets Sep 6, 2025
@doodlum doodlum merged commit 5a605cf into community-shaders:dev Sep 6, 2025
16 of 19 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants