fix(VR): disable terrain blending#1435
Conversation
WalkthroughTerrainBlending::SupportsVR() in src/Features/TerrainBlending.h was modified to return false instead of true, disabling VR support reporting for TerrainBlending. No signatures or public/exported declarations changed. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant TerrainBlending
Caller->>TerrainBlending: SupportsVR()
TerrainBlending-->>Caller: false
alt VR required
Caller->>Caller: Skip TerrainBlending path
else VR not required
Caller->>Caller: Continue non‑VR terrain flow
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Features/TerrainBlending.h (1)
100-100: Drop the extra semicolon for consistencyOther inline member definitions in this type omit a trailing semicolon after the closing brace.
Apply this diff:
- virtual bool SupportsVR() override { return false; }; + virtual bool SupportsVR() override { return false; }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/Features/TerrainBlending.h(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Do not include TODO/FIXME placeholders; provide complete, working solutions
Files:
src/Features/TerrainBlending.h
src/**/*.{cpp,cxx,cc,h,hpp,hxx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code
Files:
src/Features/TerrainBlending.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build plugin and addons
🔇 Additional comments (2)
src/Features/TerrainBlending.h (2)
100-100: VR support correctly disabled for TerrainBlendingReturning false here matches the PR intent and prevents the feature from being advertised/used in VR builds. Looks good.
100-100: The script will locate theTerrainBlending.hfile and scan the entire repository forSupportsVR()calls,TerrainBlendingreferences, and any UI/menu/settings code mentioning terrain. Once results are available, we can confirm whether VR builds correctly gate the feature and update the review comment.
|
✅ A pre-release build is available for this PR: |
Relates to issue #1414
Summary by CodeRabbit