Skip to content

fix(VR): disable terrain blending#1435

Merged
alandtse merged 1 commit into
community-shaders:devfrom
soda3000:dev-28-08-2025
Aug 28, 2025
Merged

fix(VR): disable terrain blending#1435
alandtse merged 1 commit into
community-shaders:devfrom
soda3000:dev-28-08-2025

Conversation

@soda3000
Copy link
Copy Markdown
Contributor

@soda3000 soda3000 commented Aug 28, 2025

Relates to issue #1414

Summary by CodeRabbit

  • Bug Fixes
    • Terrain Blending no longer reports VR support; VR usage with terrain blending is now disabled.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 28, 2025

Walkthrough

TerrainBlending::SupportsVR() in src/Features/TerrainBlending.h was modified to return false instead of true, disabling VR support reporting for TerrainBlending. No signatures or public/exported declarations changed.

Changes

Cohort / File(s) Summary
Terrain VR support flag
src/Features/TerrainBlending.h
Changed TerrainBlending::SupportsVR() to return false, disabling reported VR support; no API/signature changes.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant TerrainBlending

  Caller->>TerrainBlending: SupportsVR()
  TerrainBlending-->>Caller: false
  alt VR required
    Caller->>Caller: Skip TerrainBlending path
  else VR not required
    Caller->>Caller: Continue non‑VR terrain flow
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • doodlum
  • alandtse

Poem

A bunny bounds through shadered hills,
Tucks VR dreams in daffodils—
“Not today,” the nibble goes,
Terrain stays flat, the meadow knows.
Ears up, code tight, horizons clear,
We’ll hop to VR another year. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

Using provided base ref: d61defa
Using base ref: d61defa
Base commit date: 2025-08-23T12:34:46-07:00 (Saturday, August 23, 2025 12:34 PM)
No actionable suggestions for changed features.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/Features/TerrainBlending.h (1)

100-100: Drop the extra semicolon for consistency

Other inline member definitions in this type omit a trailing semicolon after the closing brace.

Apply this diff:

-	virtual bool SupportsVR() override { return false; };
+	virtual bool SupportsVR() override { return false; }
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d61defa and 1e483ed.

📒 Files selected for processing (1)
  • src/Features/TerrainBlending.h (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cxx,cc,c,h,hpp,hxx,hlsl,hlsli,fx,fxh,py}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not include TODO/FIXME placeholders; provide complete, working solutions

Files:

  • src/Features/TerrainBlending.h
src/**/*.{cpp,cxx,cc,h,hpp,hxx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{cpp,cxx,cc,h,hpp,hxx}: Ensure SE/AE/VR runtime compatibility; use runtime detection patterns (e.g., REL::RelocateMember())
Include robust error handling and resource management with graceful degradation in the plugin code

Files:

  • src/Features/TerrainBlending.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build plugin and addons
🔇 Additional comments (2)
src/Features/TerrainBlending.h (2)

100-100: VR support correctly disabled for TerrainBlending

Returning false here matches the PR intent and prevents the feature from being advertised/used in VR builds. Looks good.


100-100: The script will locate the TerrainBlending.h file and scan the entire repository for SupportsVR() calls, TerrainBlending references, and any UI/menu/settings code mentioning terrain. Once results are available, we can confirm whether VR builds correctly gate the feature and update the review comment.

@github-actions
Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@alandtse alandtse changed the title fix: corrected terrain blending vr support to false fix(VR): disable terrain blending Aug 28, 2025
@alandtse alandtse merged commit d1a9f49 into community-shaders:dev Aug 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants