Skip to content

chore: "fix(pbr): metal low-light rendering fixed, improved cubemaps" #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlum merged 1 commit into from
Aug 17, 2025
Merged

chore: "fix(pbr): metal low-light rendering fixed, improved cubemaps" #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions package/Shaders/DeferredCompositeCS.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,22 +96,18 @@ void SampleSSGISpecular(uint2 pixCoord, sh2 lobe, out float ao, out float3 il, i

float3 reflectance = ReflectanceTexture[dispatchID.xy];

// Luminance-based threshold to reduce noise compared to hard thresholds of 0.0
if (dot(reflectance, float3(0.299, 0.587, 0.114)) > 0.001) {
if (reflectance.x > 0.0 || reflectance.y > 0.0 || reflectance.z > 0.0) {
float3 normalWS = normalize(mul(FrameBuffer::CameraViewInverse[eyeIndex], float4(normalVS, 0)).xyz);

float wetnessMask = MasksTexture[dispatchID.xy].z;

normalWS = lerp(normalWS, float3(0, 0, 1), wetnessMask);

// Actual camera-to-pixel direction
float3 V = normalize(FrameBuffer::CameraPosAdjust[eyeIndex].xyz - positionWS.xyz);
float3 V = normalize(positionWS.xyz);
float3 R = reflect(V, normalWS);

float roughness = max(1.0 - glossiness, 0.02); // Prevent perfect mirrors

// Use perceptual roughness mapping for better visual distribution
float level = roughness * roughness * 7.0;
float roughness = 1.0 - glossiness;
float level = roughness * 7.0;

sh2 specularLobe = SphericalHarmonics::FauxSpecularLobe(normalWS, -V, roughness);

Expand Down
2 changes: 0 additions & 2 deletions package/Shaders/Lighting.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2986,8 +2986,6 @@ PS_OUTPUT main(PS_INPUT input, bool frontFace : SV_IsFrontFace)
specularColorPBR += indirectSpecularLobeWeight * directionalAmbientColor;
# endif
# else
// In deferred mode, metallic materials need ambient specular lighting
specularColorPBR += indirectSpecularLobeWeight * directionalAmbientColor;
indirectDiffuseLobeWeight *= vertexColor;
# endif

Expand Down