fix(VL): fix crash when VL disabled

[sicsix]

Now checks if the CS VL feature is loaded before overriding with the new compute shaders

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of volumetric lighting blur compute shaders to ensure they are only processed when the volumetric lighting feature is loaded, preventing potential errors or unexpected behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The patch updates the Renderer_DispatchCSShader::thunk function to require that the volumetric lighting feature is loaded before handling specific compute shaders for horizontal and vertical blur. This is enforced by adding a check for the vl->loaded flag in addition to the shader name.

Changes

File(s)	Summary of Changes
src/Hooks.cpp	Added checks for vl->loaded before handling blur compute shaders in Renderer_DispatchCSShader::thunk.

Sequence Diagram(s)

sequenceDiagram
    participant Renderer
    participant CSShadersSupport
    participant VolumetricLighting (vl)

    Renderer->>CSShadersSupport: DispatchCSShader(shaderName)
    CSShadersSupport->>VolumetricLighting: Check if vl is loaded
    alt vl loaded and shaderName is BlurHCS or BlurVCS
        CSShadersSupport->>VolumetricLighting: Retrieve/Create Blur Shader
        CSShadersSupport->>Renderer: Set techniqueId, dimensions, group counts
    else
        CSShadersSupport->>Renderer: Proceed with default logic
    end

Loading

Estimated code review effort

2 (30–90 minutes)

Possibly related PRs

• perf(VL): replace ping-pong dispatches with single pass #1209: Centralizes volumetric lighting shader management and adds support for blur shaders in the same function and namespace.

Suggested reviewers

• alandtse

Poem

A bunny with code in its paws,
Hopped through the volumetric fog—
"Check if it's loaded!" the rabbit declared,
Before blurring the light, so nothing is spared.
Now shaders are safe, with conditions so neat,
This patch makes the graphics complete!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b61854d and 8af8992.

📒 Files selected for processing (1)

• src/Hooks.cpp (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Using provided base ref: b61854d
Using base ref: b61854d
Base commit date: 2025-07-21T02:08:40+01:00 (Monday, July 21, 2025 02:08 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download