fix: true decal fix#1285
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis change removes all logic and data structures related to explicit handling and caching of blended decal render passes from the codebase. It simplifies the deferred rendering control flow, eliminates the Changes
Sequence Diagram(s)sequenceDiagram
participant GameEngine
participant Deferred
participant Renderer
GameEngine->>Deferred: Main_RenderWorld_Start::thunk()
alt Shader cache enabled and world state active
Deferred->>Deferred: StartDeferred()
end
Deferred->>Renderer: Call original render batches function
GameEngine->>Deferred: Main_RenderWorld_BlendedDecals::thunk()
alt Terrain blending enabled
Deferred->>Deferred: Render terrain blending
end
Deferred->>Deferred: Set inDecals = true
Deferred->>Renderer: Call original blended decals render function
Deferred->>Deferred: Set inDecals = false
Deferred->>Deferred: EndDeferred()
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
jiayev
approved these changes
Jul 19, 2025
|
✅ A pre-release build is available for this PR: |
Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.
alandtse
pushed a commit
to alandtse/open-shaders
that referenced
this pull request
Jul 20, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
True fix for decals which should work in all instances without problems.
Summary by CodeRabbit