fix(hair): hair marschner indirect diffuse inconsistency

[jiayev]

Summary by CodeRabbit

• Refactor
  • Updated how color processing is handled for hair rendering, resulting in more accurate appearance for certain lighting modes.

[github-actions]

Using provided base ref: 0ac3fba
Using base ref: 0ac3fba
Base commit date: 2025-07-18T16:09:57+01:00 (Friday, July 18, 2025 04:09 PM)
No actionable suggestions for changed features.

[coderabbitai]

Walkthrough

A call to convert the diffuseLobeWeight variable from linear to gamma space was removed in the GetHairIndirectSpecularLobeWeights function within the hair shader code. The rest of the function's logic and other gamma conversions remain unchanged.

Changes

File(s)	Change Summary
features/Hair Specular/Shaders/Hair/Hair.hlsli	Removed Color::LinearToGamma conversion on diffuseLobeWeight.

Poem

In the land where shaders gleam and glow,
A gamma step was told to go.
Diffuse lobe weights now run free,
In linear space, as they should be.
The code is lighter, bright and clear—
Hopping forward, shaders cheer!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ac3fba and 8cebabd.

📒 Files selected for processing (1)

• features/Hair Specular/Shaders/Hair/Hair.hlsli (0 hunks)

💤 Files with no reviewable changes (1)

• features/Hair Specular/Shaders/Hair/Hair.hlsli

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build plugin and addons
• GitHub Check: Validate shader compilation (Flatrim, .github/configs/shader-validation.yaml)
• GitHub Check: Validate shader compilation (VR, .github/configs/shader-validation-vr.yaml)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

✅ A pre-release build is available for this PR:
Download