Skip to content

fix: always update eye position #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 7 commits into from
Jul 14, 2025
Merged

fix: always update eye position #1253

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eaa8b34
fix: always update eye position
doodlum Jul 13, 2025
566386c
chore: vr offsets
doodlum Jul 13, 2025
0be96ea
fix: typo
doodlum Jul 13, 2025
93aa3ce
docs: explain patch
doodlum Jul 13, 2025
711ed1a
docs: more
doodlum Jul 13, 2025
4bac87e
docs: fix typo
doodlum Jul 13, 2025
08a3a71
chore: log patch
doodlum Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Hooks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,6 +1131,16 @@ namespace Hooks
stl::write_thunk_call<Main_Update_Begin>(REL::RelocationID(35565, 36564).address() + REL::Relocate(0x53, 0x6E));
stl::write_thunk_call<Main_Update_Swap>(REL::RelocationID(35565, 36564).address() + REL::Relocate(0x5D2, 0xA97));
}

// Patch eye position in BSLightingShader::SetupGeometry to always update due to additional effects which may require it
// The variable updateEyePosition is set to false by default. By patching to be true it will always update the eye position
// SE and AE use a 7-byte instruction whereas VR uses a 8-byte instruction
// We offset from the base address of the containing function to the instruction itself and then to the value the instruction sets
{
logger::info("Patching BSLightingShader::SetupGeometry::updateEyePosition");
uintptr_t setupGeometryUpdateEyePosition = REL::RelocationID(100565, 107300).address() + REL::Relocate(0x50, 0x75, 0x78);
REL::safe_write(setupGeometryUpdateEyePosition + REL::Relocate(6, 6, 7), bool{ true });
}
}

/**
Expand Down