perf: set anisotropic filtering from 16 to 8 by doodlum · Pull Request #1245 · community-shaders/skyrim-community-shaders

doodlum · 2025-07-10T13:52:45Z

Summary by CodeRabbit

New Features
- Anisotropic filtering is now capped at 8x for improved performance.
Chores
- Internal updates to enhance graphics settings management.

coderabbitai · 2025-07-10T13:52:51Z

Walkthrough

A new hook was introduced to intercept the ID3D11Device::CreateSamplerState method, modifying the sampler description to cap the anisotropic filtering level at 8x. The hook is installed via a virtual function table detour at index 23 during Direct3D device initialization, alongside existing shader creation detours.

Changes

File(s)	Change Summary
src/Hooks.cpp	Added a hook struct for `CreateSamplerState` to cap `MaxAnisotropy` at 8; updated device init to install the detour.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant D3D11Device
    participant Hook (CreateSamplerState)
    participant OriginalFunc

    App->>D3D11Device: CreateSamplerState(pSamplerDesc, ppSamplerState)
    D3D11Device->>Hook: Intercept call
    Hook->>Hook: If pSamplerDesc->MaxAnisotropy > 8, set to 8
    Hook->>OriginalFunc: Call original CreateSamplerState with modified pSamplerDesc
    OriginalFunc-->>App: Return result

Poem

In the code where graphics flow and glide,
A rabbit hopped in, anisotropy to guide.
From sixteen down to eight, the cap is set,
For smoother frames, a goal well met.
With hooks and thunks, the change is done—
Now hop along, performance won!
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be1ba9c and b6749ae.

📒 Files selected for processing (1)

src/Hooks.cpp (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/Hooks.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build plugin and addons

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.

…ders into af8

github-actions · 2025-07-10T13:54:23Z

Using provided base ref: 89d7002
Using base ref: 89d7002
Base commit date: 2025-07-10T00:46:55+01:00 (Thursday, July 10, 2025 12:46 AM)
No actionable suggestions for changed features.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Hooks.cpp (1)
295-305: Improve the anisotropy limiting logic to handle edge cases.

The current implementation only limits anisotropy when it's exactly 16, but doesn't handle other cases where MaxAnisotropy might be greater than 8. Consider using a more robust approach:
-	// Limit Anisotropy to 8x for performance
-	if (pSamplerDesc->MaxAnisotropy == 16)
-		pSamplerDesc->MaxAnisotropy = 8;
+	// Limit Anisotropy to 8x for performance
+	if (pSamplerDesc->MaxAnisotropy > 8)
+		pSamplerDesc->MaxAnisotropy = 8;
This ensures consistent performance optimization regardless of the original anisotropy setting.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89d7002 and be1ba9c.

📒 Files selected for processing (1)

src/Hooks.cpp (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

src/Hooks.cpp (1)

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#577
File: features/Wetness Effects/Shaders/WetnessEffects/WetnessEffects.hlsli:57-61
Timestamp: 2025-06-17T05:40:22.785Z
Learning: Default parameter values are supported in the HLSL compiler used by the skyrim-community-shaders project, contrary to standard HLSL (FXC/DXC) limitations.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build plugin and addons

🔇 Additional comments (1)

src/Hooks.cpp (1)

620-621: LGTM! Detour installation is correctly implemented.

The virtual function table detour is properly installed at the appropriate index and follows the established pattern in the codebase.

davo0411

looks good

github-actions · 2025-07-10T14:17:25Z

✅ A pre-release build is available for this PR:
Download

doodlum added 2 commits July 10, 2025 14:47

performance: set AF from 16 to 8

cfa089c

chore: cleanup

542f273

pre-commit-ci Bot and others added 2 commits July 10, 2025 13:53

style: 🎨 apply pre-commit.ci formatting

be1ba9c

Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.

Merge branch 'af8' of https://github.com/doodlum/skyrim-community-sha…

b6749ae

…ders into af8

coderabbitai Bot reviewed Jul 10, 2025

View reviewed changes

davo0411 approved these changes Jul 10, 2025

View reviewed changes

alandtse changed the title ~~performance: set AF from 16 to 8~~ perf: set anisotropic filtering from 16 to 8 Jul 13, 2025

alandtse merged commit 1fa8251 into dev Jul 13, 2025
17 of 19 checks passed

coderabbitai Bot mentioned this pull request Jul 13, 2025

fix: fix ctd modifying pSamplerDesc #1252

Merged

alandtse pushed a commit to alandtse/open-shaders that referenced this pull request Jul 20, 2025

perf: set anisotropic filtering from 16 to 8 (community-shaders#1245)

0bac312

coderabbitai Bot mentioned this pull request Sep 14, 2025

chore: misc improvements and fixes for 1.4 #1472

Merged

coderabbitai Bot mentioned this pull request Sep 23, 2025

chore(upscaling): simplify interop and upscale methods #1514

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: set anisotropic filtering from 16 to 8#1245

perf: set anisotropic filtering from 16 to 8#1245
alandtse merged 4 commits into
devfrom
af8

doodlum commented Jul 10, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 10, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

coderabbitai Bot left a comment

Uh oh!

davo0411 left a comment

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

doodlum commented Jul 10, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

davo0411 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

doodlum commented Jul 10, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 10, 2025 •

edited

Loading