refactor(hair): match marschner and vanilla color#1240
Merged
Conversation
…s intended, change default settings and infos
Contributor
WalkthroughThis update extends hair lighting shader functions to explicitly output a transmission lighting component alongside diffuse and specular components. It introduces configurable multipliers, refines luminance and shadow calculations, and adjusts tangent shift and roughness logic based on hair rendering mode. UI tooltip text and a default self-shadow parameter are also updated. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant Shader
App->>Shader: Call GetHairDirectLight(...)
Shader->>Shader: Compute dirDiffuse, dirSpecular, dirTransmission
Shader-->>App: Return dirDiffuse, dirSpecular, dirTransmission
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
✅ A pre-release build is available for this PR: |
Pentalimbed
reviewed
Jul 6, 2025
Pentalimbed
approved these changes
Jul 6, 2025
doodlum
approved these changes
Jul 6, 2025
alandtse
approved these changes
Jul 6, 2025
alandtse
pushed a commit
to alandtse/open-shaders
that referenced
this pull request
Jul 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make diffuse color look consistent between vanilla and maschner
also separate lighting contributions to manage them better
Summary by CodeRabbit
New Features
Improvements
User Interface
Defaults