fix: nullptr check for land in PBR TESObjectLAND_SetupMaterial

[hakasapl]

I don't think this was ever actually causing crashes, but I noticed it while debugging something else.

Just adds a nullptr check that returns false for the TESObjectLAND object

Summary by CodeRabbit

• Bug Fixes
  • Improved stability by preventing potential crashes when invalid input is detected during material setup.

[coderabbitai]

Walkthrough

A null pointer check was introduced at the beginning of the TruePBR::TESObjectLAND_SetupMaterial function to ensure the land parameter is not null before proceeding. If land is null, the function now returns false immediately. No other logic or function signatures were modified.

Changes

File(s)	Change Summary
src/TruePBR.cpp	Added a null pointer check for land in TESObjectLAND_SetupMaterial, returning false if null.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant TruePBR

    Caller->>TruePBR: TESObjectLAND_SetupMaterial(land)
    alt land is nullptr
        TruePBR-->>Caller: return false
    else land is valid
        TruePBR->>TruePBR: Proceed with material setup
        TruePBR-->>Caller: return result
    end

Loading

Possibly related PRs

• fix: support seasons swaps in PBR and TerrainHelper #1099: Modifies the call order and seasonal texture swapping logic around the same function but does not add null checks; both PRs touch TESObjectLAND_SetupMaterial with different internal focuses.

Suggested reviewers

• doodlum

Poem

In code where lands may wander null,
A rabbit hops, alert and full—
Now checks are made, mistakes are caught,
No crashing fields, no bugs are wrought!
With careful paws, the code is sure,
The land is safe, the path secure.
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3791d86 and 133930b.

📒 Files selected for processing (1)

• src/TruePBR.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build plugin and addons

🔇 Additional comments (1)

src/TruePBR.cpp (1)

1096-1098: LGTM! Good defensive programming practice.

The nullptr check prevents potential crashes from dereferencing land throughout the function (lines 1103, 1106, 1114, 1129, 1151, 1157, etc.). Returning false early is appropriate since the material setup cannot proceed without a valid land object.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

✅ A pre-release build is available for this PR:
Download