fix(llf): fix shadowed lights got ignored

[jiayev]

Summary by CodeRabbit

• Bug Fixes
  • Improved lighting behavior by expanding the criteria for certain lights to function correctly, including support for shadow lights.

[coderabbitai]

Walkthrough

The change refactors three separate thunk structs into a single templated struct ValidLight<N> with type aliases for each variant. The thunk function logic is updated to return true if a_light->IsShadowLight() is true, in addition to previous conditions on portalStrict and portalGraph.

Changes

File(s)	Change Summary
src/Features/LightLimitFix.h	Refactored ValidLight1/2/3 structs into templated ValidLight<N> with aliases; updated thunk logic to include IsShadowLight() condition.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Hooks
    participant a_light

    Caller->>Hooks: ValidLightX.thunk(a_light)
    Hooks->>a_light: Check portalStrict
    Hooks->>a_light: Check portalGraph
    Hooks->>a_light: Check IsShadowLight()
    alt Any condition true
        Hooks-->>Caller: return true
    else
        Hooks->>Hooks: Call original thunk function
        Hooks-->>Caller: return original result
    end

Loading

Possibly related PRs

• perf(llf): significantly improve scaling with many lights #1185: Introduced the original ValidLight1, ValidLight2, and ValidLight3 thunk structs and their hook implementations, which are refactored and extended in this PR.

Poem

In shadows deep where lights once played,
One template now holds the brigade.
Three thunks combined with clever art,
Checking shadows from the start.
A rabbit hops with code so bright,
Making sure the dark meets light!
🐰💡✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 149bcc4 and 1fb61df.

📒 Files selected for processing (1)

• src/Features/LightLimitFix.h (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Features/LightLimitFix.h

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build plugin and addons

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

✅ A pre-release build is available for this PR:
Download