feat: check feature compatibility (#1136)#1163
Merged
Merged
Conversation
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This allows using the build script for scripting and testing.
) * ci: treat skipped hlsl validation as success * chore: trigger cpp validation * ci: allow cpp success without changes * revert: "chore: trigger cpp validation" This reverts commit dafb4b9.
…s#1099) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat: add raindrop ripples on water * style: 🎨 apply clang-format changes * feat: ripple effect now supports water parallax * style: 🎨 apply clang-format changes * fix: fix compilation errors * fix: fix wrong type Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: sync cache on defaults Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * style: 🎨 apply pre-commit.ci formatting Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. * fix: vanilla ripple display * refactor: add flowmap functions * feat: add flow maps to ripples * style: 🎨 apply pre-commit.ci formatting Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. * fix: fix ripple and splash flows * fix: remove dupe GetFeatureModLink * style: fix lint * refactor: address further ai comments * fix: avoid entropy collapse in ripple hash * style: restore function names and lines --------- Co-authored-by: TheRiverwoodModder <TheRiverwoodModder@users.noreply.github.com> Co-authored-by: Alan Tse <alandtse@users.noreply.github.com> Co-authored-by: Alan Tse <alandtse@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Full Icon framework & support. * UI Text helper function for better looking large text Function for crispier large text like titles. Helps subtly but does make a difference, especially when high-res icons are visible near text. * Update Menu.cpp * Update src/UIIconLoader.cpp Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/UIIconLoader.cpp Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Icon folder changes, fix for compile issue. * Reorganise * Update README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fixes * rabbit suggested fixes * fix * style: 🎨 apply pre-commit.ci formatting Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. * build fix * Fixes * Update Menu.cpp * style: 🎨 apply pre-commit.ci formatting Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. * Licence tweaks * Comment clean & Mipmap fixes * Texture memory leak cleanup * fixes * style: 🎨 apply pre-commit.ci formatting Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. * style: 🎨 apply pre-commit.ci formatting Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces a comprehensive set of changes including new shader validation infrastructure (documentation, PowerShell script, CMake target, and workflow integration), a modular BRDF shader library, major UI enhancements with icon support and feature categorization, improved feature issue detection and management, new utility modules for file system and UI operations, and several feature-specific logic and settings updates. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHubActions
participant PowerShellScript
participant hlslkit
participant CMake
participant Game
User->>GitHubActions: Push or PR triggers workflow
GitHubActions->>GitHubActions: check-changes job (detects file changes)
GitHubActions->>CMake: cpp-build job (if needed)
GitHubActions->>PowerShellScript: shader-validation job (if needed)
PowerShellScript->>Game: (requires shader logs from game run)
PowerShellScript->>hlslkit: Generate shader config YAMLs
PowerShellScript-->>GitHubActions: Outputs configs for validation
GitHubActions->>hlslkit: Validate shader compilation using configs
hlslkit-->>GitHubActions: Reports validation results
GitHubActions->>User: Uploads artifacts, reports status
sequenceDiagram
participant Menu
participant User
participant Feature
participant FeatureIssues
User->>Menu: Open settings UI
Menu->>Feature: Query feature list
Feature->>Menu: Return features with categories
Menu->>Menu: Group features by category, display headers
User->>Menu: Select feature or category
Menu->>Feature: Show feature settings or issues
FeatureIssues->>Menu: If issues exist, show "Feature Issues" menu
User->>Menu: Interact with icon buttons (save, load, clear cache)
Menu->>Menu: Perform actions, show tooltips/icons
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (54)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This was referenced Nov 17, 2025
Closed
This was referenced Dec 10, 2025
Merged
This was referenced Dec 25, 2025
Closed
This was referenced Feb 13, 2026
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Summary by CodeRabbit
New Features
Improvements
Documentation
Chores
Style
Bug Fixes