fix: Performance Overlay menu width

[davo0411]

Sets a fixed width for the perf overlay menu as it would rapidly change when graphs were disabled with the background enabled.

Summary by CodeRabbit

• Bug Fixes
  • Improved the stability of the performance overlay window size, preventing rapid resizing when only textual performance data is displayed.

[coderabbitai]

Walkthrough

A conditional block was added to the Menu::DrawPerfOverlay() function to set a fixed window width when performance graphs are not displayed. This ensures the overlay window maintains a stable width, preventing size fluctuations when only textual performance data is shown.

Changes

File	Change Summary
src/Menu.cpp	Added logic in DrawPerfOverlay() to set a fixed window width when performance graphs are not enabled.

Poem

A window once danced, wide and thin,
Now stands steady, holding in
Text that tells the tale of speed—
No more shrinking, no more greed.
The overlay calm, the numbers bright,
Thanks to a tweak that set things right!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Menu.cpp (1)

1195-1200: LGTM! Effective solution for preventing overlay width fluctuations.

The conditional logic correctly addresses the stated issue by setting a fixed width when graphs are disabled. The text scale multiplication ensures proper scaling across different font sizes, and the automatic height (0) allows for appropriate vertical sizing.

Consider extracting the magic number to improve maintainability:

+	static constexpr float OVERLAY_FIXED_WIDTH = 325.0f;
+
 	// Set window size based on whether graphs are shown, was rapidly changing size based on text
 	bool hasGraphs = settings.PerfOverlay.ShowPreFGFrameTimeGraph || settings.PerfOverlay.ShowPostFGFrameTimeGraph;
 	if (!hasGraphs) {
-		float fixedWidth = 325.0f * textScale;
+		float fixedWidth = OVERLAY_FIXED_WIDTH * textScale;
 		ImGui::SetNextWindowSize(ImVec2(fixedWidth, 0), ImGuiCond_Always);
 	}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 447957a and cc6d3df.

📒 Files selected for processing (1)

• src/Menu.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build plugin and addons

[github-actions]

✅ A pre-release build is available for this PR:
Download